Skip to content
This repository was archived by the owner on Feb 10, 2026. It is now read-only.

FCE-2149: Picture in Picture improvements Android - #506

Merged
MiloszFilimowski merged 16 commits into
mainfrom
mfilimowski/FCE-2149-pip-android
Oct 28, 2025
Merged

FCE-2149: Picture in Picture improvements Android#506
MiloszFilimowski merged 16 commits into
mainfrom
mfilimowski/FCE-2149-pip-android

Conversation

@MiloszFilimowski

@MiloszFilimowski MiloszFilimowski commented Oct 27, 2025

Copy link
Copy Markdown
Collaborator

Description

  • Fixed Android scaling/positioning by using SurfaceViewRenderer directly instead of view transforms
  • Fixed PiP UI

TODO: There are still some problems with VAD activation and metadata detection which will be fixed in FCE-2175

Documentation impact

  • Documentation update required
  • Documentation updated in another PR
  • No documentation update required

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)

@linear

linear Bot commented Oct 27, 2025

Copy link
Copy Markdown

@MiloszFilimowski MiloszFilimowski changed the title Picture in Picture improvements Android FCE-2175: Picture in Picture improvements Android Oct 27, 2025
@linear

linear Bot commented Oct 27, 2025

Copy link
Copy Markdown

@MiloszFilimowski
MiloszFilimowski marked this pull request as ready for review October 27, 2025 08:54
@MiloszFilimowski MiloszFilimowski changed the title FCE-2175: Picture in Picture improvements Android FCE-2149: Picture in Picture improvements Android Oct 27, 2025

@anna1901 anna1901 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I tested I noticed that:

  • id is displayed instead of the correct displayName (because of the nesting inside of the metadata)
  • when I had camera turned off, I though there should be a "No camera" text on the left side of the split screen, but there was only black screen
  • the video from the second track was not displayed at all in the pip (but it was visible in the app)

@anna1901 anna1901 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@MiloszFilimowski
MiloszFilimowski merged commit 1b89c6a into main Oct 28, 2025
5 checks passed
@MiloszFilimowski
MiloszFilimowski deleted the mfilimowski/FCE-2149-pip-android branch October 28, 2025 16:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants