This repository was archived by the owner on Feb 10, 2026. It is now read-only.
FCE-2189: Fix track updates in PiP on iOS - #508
Merged
Conversation
MiloszFilimowski
approved these changes
Oct 29, 2025
| displayName: displayName, | ||
| hasVideoTrack: true | ||
| ) | ||
| return trackToTrackInfo(videoTrack: videoTrack, endpoint: endpoint) |
Collaborator
There was a problem hiding this comment.
suggestion: It might make it more swifty if this was an extension on Endpoint. Tracks are already inside. endpoint.trackInfo would look cleaner.
Contributor
Author
There was a problem hiding this comment.
But I would still have to pass video track, because the logic for selecting it is inside the manager, or am I wrong?
| @@ -127,22 +115,30 @@ class PictureInPictureManager { | |||
| // Fallback: return first available remote peer with video track | |||
| for endpoint in remoteEndpoints { | |||
| if let videoTrack = endpoint.tracks.values.first(where: { $0 is RemoteVideoTrack }) as? RemoteVideoTrack { | |||
Collaborator
There was a problem hiding this comment.
issue: I only noticed this right now (I know I wrote the code). But I think if the user doesn't have a video track but is sharing his screen, we won't show anything. Does it make sense to create a new task out of this issue?
Contributor
Author
There was a problem hiding this comment.
Yes, that's true, it does
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is a bug, where sometimes both primary and secondary video tracks are not displayed if pip is opened too soon, but it will be fixed in a separate task
Documentation impact
Types of changes
not work as expected)