Skip to content

Conversation

fivetran-joemarkiewicz
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz commented Jul 14, 2025

PR Overview

Package version introduced in this PR: v0.21.0

This PR addresses the following Issue/Feature(s): Issue #145

Summary of changes:

Renamed the is_closed_won column within the stg_hubspot__deal_pipeline_stage model to is_closed. This was done to more accurately reflect the source data as this column represents the state of the deal pipeline and not necessarily if it was won or not. To determine this, the pipeline_stage_label can be used.

Additionally, highlighted the deprecation of the closed_won column at the source in favor of the is_closed column.

Submission Checklist

  • Alignment meeting with the reviewer (if needed)
    • Timeline and validation requirements discussed
  • Provide validation details:
    • Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
      • Confirmed changes ran as expected as well as tests passed. Additionally, see downstream PR #161 for further validation of these changes working as expected.
    • Testing Instructions: Confirm the change addresses the issue(s)
      • See internal ticket for further testing instructions. Running locally and verifying downstream models run without error should prove sufficient.
    • Focus Areas: Complex logic or queries that need extra attention
      • Verify all changes are accounted and models are running as expected.

Changelog

  • Draft changelog for PR
  • Final changelog for release review

@fivetran-joemarkiewicz fivetran-joemarkiewicz marked this pull request as ready for review July 14, 2025 20:01
* Q2 FY26: Apply automated update.

* Update README.md

---------

Co-authored-by: fivetran-catfritz <[email protected]>
Co-authored-by: Joe Markiewicz <[email protected]>
Copy link
Contributor

@fivetran-catfritz fivetran-catfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fivetran-catfritz fivetran-catfritz added the docs:ready Triggers the docs generator workflow. label Jul 22, 2025
CHANGELOG.md Outdated
|-----------|----------------|--------------|--------------|---------|
| [stg_hubspot__deal_pipeline_stage](https://fivetran.github.io/dbt_hubspot_source/#!/model/model.hubspot_source.stg_hubspot__deal_pipeline_stage) | Column Renamed | `is_closed_won` | `is_closed` | Column renamed to more accurately match the source data. The renamed `is_closed` column is generated via a coalesce between the previous `closed_won` source column and the newly added `is_closed` column. This renamed column represents whether a deal is closed, regardless of its label as “Closed Won” or “Closed Lost.” You can still use the `pipeline_stage_label` column to differentiate between "Closed Won" and "Closed Lost" stages. |

## Feature Updates
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are kinda more Under the Hood

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@fivetran-joemarkiewicz fivetran-joemarkiewicz added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. labels Jul 24, 2025
@fivetran-joemarkiewicz fivetran-joemarkiewicz changed the base branch from main to release/v0.21.0 July 24, 2025 21:58
@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit 5025162 into release/v0.21.0 Jul 24, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs:ready Triggers the docs generator workflow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants