-
Notifications
You must be signed in to change notification settings - Fork 34
feature/is-closed-support #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/is-closed-support #146
Conversation
* Q2 FY26: Apply automated update. * Update README.md --------- Co-authored-by: fivetran-catfritz <[email protected]> Co-authored-by: Joe Markiewicz <[email protected]>
Co-authored-by: fivetran-catfritz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
CHANGELOG.md
Outdated
|-----------|----------------|--------------|--------------|---------| | ||
| [stg_hubspot__deal_pipeline_stage](https://fivetran.github.io/dbt_hubspot_source/#!/model/model.hubspot_source.stg_hubspot__deal_pipeline_stage) | Column Renamed | `is_closed_won` | `is_closed` | Column renamed to more accurately match the source data. The renamed `is_closed` column is generated via a coalesce between the previous `closed_won` source column and the newly added `is_closed` column. This renamed column represents whether a deal is closed, regardless of its label as “Closed Won” or “Closed Lost.” You can still use the `pipeline_stage_label` column to differentiate between "Closed Won" and "Closed Lost" stages. | | ||
|
||
## Feature Updates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are kinda more Under the Hood
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
Co-authored-by: Jamie Rodriguez <[email protected]>
PR Overview
Package version introduced in this PR: v0.21.0
This PR addresses the following Issue/Feature(s): Issue #145
Summary of changes:
Renamed the
is_closed_won
column within thestg_hubspot__deal_pipeline_stage
model tois_closed
. This was done to more accurately reflect the source data as this column represents the state of the deal pipeline and not necessarily if it was won or not. To determine this, thepipeline_stage_label
can be used.Additionally, highlighted the deprecation of the
closed_won
column at the source in favor of theis_closed
column.Submission Checklist
Changelog