[Bug Fix] Ticket pipeline id casting #151

fivetran-avinash · 2025-07-25T19:51:17Z

PR Overview

Package version introduced in this PR:

v0.21.0 (release branch merged in to smooth merge conflicts, none of the changes overlap with this PR)

This PR addresses the following Issue/Feature(s):

[Bug] Support string ticket_pipeline_id fields #148

Summary of changes:

Reverted ticket pipeline identifiers back to the original string format to prevent datatype errors in compilation. This is a data type columnar change, and thus a breaking change.

Submission Checklist

Alignment meeting with the reviewer (if needed)
- Timeline and validation requirements discussed
Provide validation details:
- Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
- Testing Instructions: Confirm the change addresses the issue(s)
- Focus Areas: Complex logic or queries that need extra attention
Merge any relevant open PRs into this PR (release/v0.21.0 #150)

Changelog

Draft changelog for PR
Final changelog for release review

* feature/is-closed-support * additional updates * Q2 FY26 Automatic Package Updates (#147) * Q2 FY26: Apply automated update. * Update README.md --------- Co-authored-by: fivetran-catfritz <[email protected]> Co-authored-by: Joe Markiewicz <[email protected]> * Update CHANGELOG.md * Q2 FY26: Update auto-release workflow only. (#149) Co-authored-by: fivetran-catfritz <[email protected]> * Generate dbt docs via GitHub Actions * Apply suggestions from code review Co-authored-by: Jamie Rodriguez <[email protected]> * Update CHANGELOG.md * Generate dbt docs via GitHub Actions --------- Co-authored-by: Fivetran Maintainer Bot <[email protected]> Co-authored-by: fivetran-catfritz <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Jamie Rodriguez <[email protected]>

…/fivetran/dbt_hubspot_source into bugfix/ticket-pipeline-id-casting

fivetran-jamie

Overall looks good, but I think we also need to explicitly cast ticket.ticket_pipeline_id and ticket. ticket_pipeline_stage_id as strings here due to these joins downstream. Seeing No matching signature for operator = for argument types: INT64, STRING Signature: T1 = T1 failures when running this on some internal data

fivetran-jamie · 2025-07-28T18:13:26Z

CHANGELOG.md

+| [`stg_hubspot__ticket_pipeline_stage`](https://fivetran.github.io/dbt_hubspot_source/#!/model/model.hubspot_source.stg_hubspot__ticket_pipeline_stage) | Column datatype | `ticket_pipeline_id` (`int`)<br/> `ticket_pipeline_stage_id` (`int`)  | `ticket_pipeline_id` (`string`)<br/> `ticket_pipeline_stage_id` (`string`)  | Reverted ticket pipeline identifiers back to their original string format to prevent datatype errors in compilation. [PR #151](https://github.com/fivetran/dbt_hubspot_source/pull/151)   |
+
+## Under the Hood 
+- Updated seed files to validate that the new identifiers compile as expected in both the source and transform packages.[PR #151](https://github.com/fivetran/dbt_hubspot_source/pull/151)


Suggested change

- Updated seed files to validate that the new identifiers compile as expected in both the source and transform packages.[PR #151](https://github.com/fivetran/dbt_hubspot_source/pull/151)

- Updated seed files to validate that the new identifiers compile as expected in both the source and transform packages. [PR #151](https://github.com/fivetran/dbt_hubspot_source/pull/151)

fivetran-jamie · 2025-07-28T18:15:24Z

models/src_hubspot.yml

              NOTE: This field is deprecated in favor of the `is_closed` column.
          - name: is_closed
-            description: Boolean indicating if the pipeline stage is closed.
+            description: Boolean indicating if the pipeline stage is closed.      


Suggested change

description: Boolean indicating if the pipeline stage is closed.

description: Boolean indicating if the pipeline stage is closed.

Since trailing whitespace is becoming an issue for python 3.12

Removed whitespace

fivetran-jamie · 2025-07-28T18:16:15Z

models/src_hubspot.yml

+              Boolean indicating if the pipeline stage is closed. 
+              


Suggested change

Boolean indicating if the pipeline stage is closed.

Boolean indicating if the pipeline stage is closed.

Removed whitespace

fivetran-jamie · 2025-07-28T18:17:38Z

models/stg_hubspot__deal.yml

+      - name: is_closed 
+        description: Boolean indicating if the pipeline stage is closed. For the state of the closed deal ("Closed Won" vs "Closed Lost"), refer to the pipeline_stage_label column.      


Suggested change

- name: is_closed

description: Boolean indicating if the pipeline stage is closed. For the state of the closed deal ("Closed Won" vs "Closed Lost"), refer to the pipeline_stage_label column.

- name: is_closed

description: Boolean indicating if the pipeline stage is closed. For the state of the closed deal ("Closed Won" vs "Closed Lost"), refer to the pipeline_stage_label column.

To avoid introducing any whitespace issues

Removed whitespace

fivetran-jamie · 2025-07-28T18:19:17Z

models/stg_hubspot__ticket_pipeline.sql


    select
-        cast(pipeline_id as {{ dbt.type_int() }} ) as ticket_pipeline_id,
+        pipeline_id as ticket_pipeline_id,


Is this guaranteed to always come in as a string? Wondering if we should do a cast(pipeline_id as {{ dbt.type_string() }} ) just in case

Updated to cast as strings.

fivetran-jamie · 2025-07-28T18:22:29Z

models/stg_hubspot__ticket_pipeline_stage.sql

+        pipeline_id as ticket_pipeline_id,
+        stage_id as ticket_pipeline_stage_id,


Same cast-as-string question as above

Updated to cast as strings.

…m/fivetran/dbt_hubspot_source into bugfix/ticket-pipeline-id-casting

fivetran-avinash

@fivetran-jamie Agreed that explicitly casting all ticket pipeline identifiers as a string makes sense given the errors you're seeing. Applied them and resolved the errors you're seeing.

Ready for re-review!

fivetran-jamie

Looks great! just some final questions/comments in the changelog

fivetran-jamie · 2025-07-29T14:13:06Z

CHANGELOG.md

+| Data Models | Change Type | Old Behavior | New Behavior | Notes |
+| --- | --- | --- | --- | --- |
+| [`stg_hubspot__deal_pipeline_stage`](https://fivetran.github.io/dbt_hubspot_source/#!/model/model.hubspot_source.stg_hubspot__deal_pipeline_stage) | Column Renamed | `is_closed_won` | `is_closed` | Column renamed to more accurately match the source data. The renamed `is_closed` column is generated via a coalesce between the previous `closed_won` source column and the newly added `is_closed` column. This renamed column represents whether a deal is closed, regardless of its label as “Closed Won” or “Closed Lost.” You can still use the `pipeline_stage_label` column to differentiate between "Closed Won" and "Closed Lost" stages. ([PR #146](https://github.com/fivetran/dbt_hubspot_source/pull/146)) |
+| [`stg_hubspot__ticket`](https://fivetran.github.io/dbt_hubspot_source/#!/model/model.hubspot_source.stg_hubspot__ticket) | Column datatype | `ticket_pipeline_id` (numeric string)<br/> `ticket_pipeline_stage_id` (numeric string) | `ticket_pipeline_id` (`string`)<br/> `ticket_pipeline_stage_id` (`string`)  | Explicitly cast ticket pipeline identifiers to string format to prevent datatype errors in compilation; if the values in `ticket` were entirely numerics, the data type could be erroneously interpreted as an integer. ([PR #151](https://github.com/fivetran/dbt_hubspot_source/pull/151)) |


numeric string for the old data types is a lil confusing -- would int be more appropriate? In a similar vein, regarding the below note, do you know for certain that these ticket fields ever come in as strings?

if the values in ticket were entirely numerics, the data type could be erroneously interpreted as an integer.

Updated after our sync.

fivetran-jamie · 2025-07-29T14:19:29Z

models/stg_hubspot__deal.yml

        description: Whether the pipeline stage is currently in use.
      - name: is_closed
-        description: Boolean indicating if the pipeline stage is closed. For the state of the closed deal ("Closed Won" vs "Closed Lost"), refer to the pipeline_stage_label column.
+        description: Boolean indicating if the pipeline stage is closed. For the state of the closed deal ("Closed Won" vs "Closed Lost"), refer to the pipeline_stage_label column.      


Suggested change

description: Boolean indicating if the pipeline stage is closed. For the state of the closed deal ("Closed Won" vs "Closed Lost"), refer to the pipeline_stage_label column.

description: Boolean indicating if the pipeline stage is closed. For the state of the closed deal ("Closed Won" vs "Closed Lost"), refer to the pipeline_stage_label column.

Removed whitespace.

…m/fivetran/dbt_hubspot_source into bugfix/ticket-pipeline-id-casting

fivetran-jamie

LGTM!

fivetran-catfritz · 2025-07-30T15:45:23Z

CHANGELOG.md

+| [`stg_hubspot__ticket`](https://fivetran.github.io/dbt_hubspot_source/#!/model/model.hubspot_source.stg_hubspot__ticket) | Column datatype | `ticket_pipeline_id` (`int` or `string`)<br/> `ticket_pipeline_stage_id` (`int` or `string`) | `ticket_pipeline_id` (`string`)<br/> `ticket_pipeline_stage_id` (`string`)  | Explicitly cast ticket pipeline identifiers to string format to prevent datatype errors in compilation. ([PR #151](https://github.com/fivetran/dbt_hubspot_source/pull/151)) |
+| [`stg_hubspot__ticket_pipeline`](https://fivetran.github.io/dbt_hubspot_source/#!/model/model.hubspot_source.stg_hubspot__ticket_pipeline) | Column datatype | `ticket_pipeline_id` (`int`) | `ticket_pipeline_id` (`string`) | Changed cast of ticket pipeline identifier to the original string format to prevent datatype errors in compilation. ([PR #151](https://github.com/fivetran/dbt_hubspot_source/pull/151)) |
+| [`stg_hubspot__ticket_pipeline_stage`](https://fivetran.github.io/dbt_hubspot_source/#!/model/model.hubspot_source.stg_hubspot__ticket_pipeline_stage) | Column datatype | `ticket_pipeline_id` (`int`)<br/> `ticket_pipeline_stage_id` (`int`)  | `ticket_pipeline_id` (`string`)<br/> `ticket_pipeline_stage_id` (`string`)  | Changed cast of ticket pipeline identifiers to their original string format to prevent datatype errors in compilation. ([PR #151](https://github.com/fivetran/dbt_hubspot_source/pull/151)) |


Since we have multiple columns with the same change, I suggest to format these lines like in this release to help with readability.

fivetran-catfritz

One more small suggestion I left, but looks good for release!

CHANGELOG.md

Co-authored-by: fivetran-catfritz <[email protected]>

…m/fivetran/dbt_hubspot_source into bugfix/ticket-pipeline-id-casting

fivetran-avinash and others added 5 commits July 24, 2025 14:26

changes

143e9fe

release/v0.21.0

1816621

model/seed updates

120b4d7

model/seed updates + merge in release branch

4fb17a9

fivetran-avinash self-assigned this Jul 25, 2025

fivetran-avinash changed the base branch from main to release/v0.21.0 July 25, 2025 20:32

Merge branch 'release/v0.21.0' into bugfix/ticket-pipeline-id-casting

50bb8a3

fivetran-avinash added the docs:ready Triggers the docs generator workflow. label Jul 25, 2025

github-actions bot and others added 4 commits July 25, 2025 21:01

Generate dbt docs via GitHub Actions

26f3d82

casting

710403c

erge branch 'bugfix/ticket-pipeline-id-casting' of https://github.com…

4b53467

…/fivetran/dbt_hubspot_source into bugfix/ticket-pipeline-id-casting

uncomment seeds

36dd84b

fivetran-avinash added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. labels Jul 28, 2025

Generate dbt docs via GitHub Actions

540c9b9

fivetran-jamie requested changes Jul 28, 2025

View reviewed changes

fivetran-avinash added 5 commits July 28, 2025 13:28

PR suggestions

e58f66b

PR suggestions

52cb3e2

Merge branch 'bugfix/ticket-pipeline-id-casting' of https://github.co…

9c9531f

…m/fivetran/dbt_hubspot_source into bugfix/ticket-pipeline-id-casting

cast fix

ef33562

CHANGELOG

75cd80e

fivetran-avinash commented Jul 28, 2025

View reviewed changes

fivetran-avinash added 3 commits July 28, 2025 15:28

CHANGELOG

13aed80

schema

05e95cb

schema

7c1a2ab

fivetran-avinash added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. labels Jul 28, 2025

Generate dbt docs via GitHub Actions

142c9a3

fivetran-jamie reviewed Jul 29, 2025

View reviewed changes

fivetran-joemarkiewicz changed the base branch from release/v0.21.0 to main July 29, 2025 17:02

fivetran-avinash added 2 commits July 29, 2025 13:14

PR suggestions

3094b38

Merge branch 'bugfix/ticket-pipeline-id-casting' of https://github.co…

de389cb

…m/fivetran/dbt_hubspot_source into bugfix/ticket-pipeline-id-casting

fivetran-jamie approved these changes Jul 29, 2025

View reviewed changes

fivetran-avinash added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. labels Jul 29, 2025

Generate dbt docs via GitHub Actions

d03c659

fivetran-catfritz reviewed Jul 30, 2025

View reviewed changes

CHANGELOG

a34962e

fivetran-catfritz approved these changes Jul 30, 2025

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

fivetran-avinash and others added 4 commits July 30, 2025 15:11

Update CHANGELOG.md

d0f6026

Co-authored-by: fivetran-catfritz <[email protected]>

schema bump

6cb5d8d

Merge branch 'bugfix/ticket-pipeline-id-casting' of https://github.co…

4be903f

…m/fivetran/dbt_hubspot_source into bugfix/ticket-pipeline-id-casting

Schema

bf59518

fivetran-avinash added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. labels Jul 31, 2025

Generate dbt docs via GitHub Actions

d31d293

fivetran-avinash merged commit 11f5fc6 into main Jul 31, 2025
9 checks passed

	- Updated seed files to validate that the new identifiers compile as expected in both the source and transform packages.[PR #151](https://github.com/fivetran/dbt_hubspot_source/pull/151)
	- Updated seed files to validate that the new identifiers compile as expected in both the source and transform packages. [PR #151](https://github.com/fivetran/dbt_hubspot_source/pull/151)

	description: Boolean indicating if the pipeline stage is closed.
	description: Boolean indicating if the pipeline stage is closed.

	Boolean indicating if the pipeline stage is closed.

	Boolean indicating if the pipeline stage is closed.

		- name: is_closed
		description: Boolean indicating if the pipeline stage is closed. For the state of the closed deal ("Closed Won" vs "Closed Lost"), refer to the pipeline_stage_label column.

		pipeline_id as ticket_pipeline_id,
		stage_id as ticket_pipeline_stage_id,

[Bug Fix] Ticket pipeline id casting #151

[Bug Fix] Ticket pipeline id casting #151

Uh oh!

Conversation

fivetran-avinash commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Overview

Submission Checklist

Changelog

Uh oh!

fivetran-jamie left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fivetran-avinash left a comment

Choose a reason for hiding this comment

Uh oh!

fivetran-jamie left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fivetran-jamie left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fivetran-catfritz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fivetran-avinash commented Jul 25, 2025 •

edited

Loading