Skip to content

Consolidate source + remove tests#145

Merged
fivetran-catfritz merged 8 commits into
mainfrom
MagicBot/consolidate-source-package
Aug 14, 2025
Merged

Consolidate source + remove tests#145
fivetran-catfritz merged 8 commits into
mainfrom
MagicBot/consolidate-source-package

Conversation

@fivetran-data-model-bot

@fivetran-data-model-bot fivetran-data-model-bot commented Aug 12, 2025 •
edited by fivetran-catfritz
Loading

Copy link
Copy Markdown
Contributor

Summary

This PR is to combine the source and transform packages and remove tests not compatible with dbt Fusion 1.10.6+.

Please check the below automated updates were successful:

MANUAL UPDATES

  • If applicable, merge in the Q2 FY26 Automatic Package Updates PR.
  • If there are 2 docs.md files, consolidate the definitions the file in the main folder and remove the 2nd file.
  • Scan the README for non-standard references to the source package and remove or update.
  • Copy the passthrough vars or other non-standard vars from the source dbt_project.yml to the transform dbt_project.yml.
  • Check BK run logs for at least 2 warehouses
    • No further deprecation warnings
    • No union data "table not found" type warnings
  • Make sure below automatic updates were applied correctly.

Source + Transform Consolidation

  • Moved models/macros to models/staging/ and macros/staging/.
  • Updated all var('') references within models to use ref('stg_jira__').
  • Updated vars in dbt_project.yml from refs to sources.
  • Removed the source package from packages.yml.
  • Major version bump to v1.0.0 (or higher if applicable)

dbt Fusion Compatibility

  • Removed dbt_utils.unique_combination_of_columns test
  • Accepted values tests were removed where applicable (Shopify, NetSuite, QuickBooks).

YAML & Config Updates

  • Moved loaded_at_field under config: in src.yml, grouped with freshness
  • Added +schema and +materialization for the staging models in dbt_project.yml.

README

  • Removed references to the source package in:
    • Overview
    • Installation instructions
    • Dependencies list
    • Schema override examples

@fivetran-data-model-bot fivetran-data-model-bot added the next-release Include in the next release. label Aug 12, 2025
fivetran-joemarkiewicz and others added 3 commits August 13, 2025 22:29
@fivetran-joemarkiewicz
Update issue.csv (#141)
d31fbf1
@fivetran-data-model-bot @fivetran-catfritz
Q2 FY26 Automatic Package Updates (#142)
f48351a 
* Q2 FY26: Apply automated update.

* Q2 FY26: Update auto-release workflow only.

---------

Co-authored-by: fivetran-catfritz <111930712+fivetran-catfritz@users.noreply.github.com>
@fivetran-catfritz
fixes
a031ddb
@fivetran-catfritz fivetran-catfritz self-assigned this Aug 14, 2025
@fivetran-catfritz fivetran-catfritz added the docs:ready Triggers the docs generator workflow. label Aug 14, 2025
fivetran-catfritz
fivetran-catfritz reviewed Aug 14, 2025
View reviewed changes
Comment thread integration_tests/seeds/issue.csv
id,_fivetran_deleted,_fivetran_synced,_original_estimate,_remaining_estimate,_time_spent,assignee,created,creator,description,due_date,environment,issue_type,key,last_viewed,original_estimate,parent_id,priority,project,remaining_estimate,reporter,resolution,resolved,status,status_category_changed,summary,time_spent,updated,work_ratio,work_type
10011,FALSE,2020-11-06 22:23:38,,,,,2020-04-01 08:33:58,5c3326c24b248c315badf3ee,"Yes, this is an issue to test permissions",,,10103,TP-8,,,,3,10001,,5c3326c24b248c315badf3ee,,2020-05-29 11:33:53,3,2020-04-01 08:34:02,We want to test permissions,,2020-05-29 11:33:53,-1,10103
10015,FALSE,2020-11-06 22:23:41,,,,,2020-06-11 07:38:03,5ed0edbe2999b60c23255b4f,,,,,TP-12,,,,5,10001,,5ed0edbe2999b60c23255b4f,,2020-06-11 07:38:03,10003,2020-06-11 07:38:03,Part of test epic,,2020-06-11 07:38:03,-1,10103
10018,FALSE,2020-11-12 12:20:50,,,,,2020-11-10 19:11:45,557058:a9572f6a-3041-435a-96ed-5286e3811b33,,,,10103,TCP-1,2020-11-10 19:11:46,,,3,10005,,557058:a9572f6a-3041-435a-96ed-5286e3811b33,,2020-11-28 19:11:45,10003,2020-11-28 19:11:46,this is a story,,2020-11-28 19:11:45,-1,

@fivetran-catfritz fivetran-catfritz Aug 14, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note this was brough in from a next-release pr.

fivetran-jamie
fivetran-jamie approved these changes Aug 14, 2025
View reviewed changes

@fivetran-jamie fivetran-jamie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread CHANGELOG.md Outdated
@fivetran-catfritz @fivetran-jamie
Update CHANGELOG.md
ca8186d 
Co-authored-by: Jamie Rodriguez <65564846+fivetran-jamie@users.noreply.github.com>
@fivetran-catfritz fivetran-catfritz merged commit b5aa419 into main Aug 14, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fivetran-catfritz fivetran-catfritz fivetran-catfritz left review comments
@fivetran-jamie fivetran-jamie fivetran-jamie approved these changes

Assignees

@fivetran-catfritz fivetran-catfritz

Labels

docs:ready Triggers the docs generator workflow. next-release Include in the next release.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fivetran-data-model-bot @fivetran-jamie @fivetran-catfritz @fivetran-joemarkiewicz