-
Notifications
You must be signed in to change notification settings - Fork 2
Feature( connector-sdk ) : Example for fetching data from IBM DB2 database #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This pull request has been linked to and will mark 1 task as "Done" when merged:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces an example connector for fetching and upserting data from an IBM DB2 database using the Fivetran Connector SDK.
- Adds a new connector example in Python (connector.py) for IBM DB2.
- Provides supporting documentation in a dedicated README file and updates the main README to include the new example.
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
examples/source_examples/ibm_db2/connector.py | New connector code for IBM DB2 including connection, sample data, and upsert logic. |
examples/source_examples/ibm_db2/README.md | Documentation for configuring and using the IBM DB2 connector. |
README.md | Updates to list the IBM DB2 example in the project examples. |
Files not reviewed (2)
- examples/source_examples/ibm_db2/configuration.json: Language not supported
- examples/source_examples/ibm_db2/requirements.txt: Language not supported
- `create_sample_table_into_db()`: This method is used to create a sample table in the database. | ||
- `insert_sample_data_into_table()`: This method is used to insert sample data into the table. | ||
|
||
> IMPORTANT: This example code has not been fully tested in all environments. If you encounter any issues implementing this connector, please use Fivetran's [Save Me Time](https://support.fivetran.com/hc/en-us/requests/new?isSdkIssue=true) service. Our support team will be happy to help troubleshoot and finalize any issues with this example. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed? We should at least check our examples thoroughly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The testing has been done using the local DB2 server ( setting host as localhost ). It works fine.
I could not test it with fivetran deploy
due to lack of credentials.
Discussed with Alison : https://fivetran.height.app/T-930742#activityId=526703f3-cd44-40a3-b9a0-cf826debb036
Requested for a free tier IBM Cloud credentials. Once it is there, we can test it with the deploy
command
closes https://fivetran.height.app/T-930742
What it does
Validation
fivetran debug