Add history mode guide#49
Draft
fivetran-abdulsalam wants to merge 14 commits into
Draft
Conversation
manjutapali
approved these changes
Jun 18, 2024
manjutapali
left a comment
manjutapali
left a comment
Collaborator
There was a problem hiding this comment.
Looks good.
Please get review from @5tran-alexil.
5tran-alexil
requested changes
Jun 18, 2024
5tran-alexil
left a comment
5tran-alexil
left a comment
Contributor
There was a problem hiding this comment.
@fivetran-abdulsalam throughout the files, add articles using the suggestiuons as references, add "as follows" to "will be", add the relevant actor ("we" or "you need to" in sentences like:
"Check for corresponding earliest record(_fivetran_earliest TRUE), DELETE the existing records from destination table if _fivetran_start of destination table is greater than or equal to _fivetran_start of batch file(in above example yes, so deleted id = 1 with _fivetran_start = T3 and T4)"
5tran-alexil
approved these changes
Jun 20, 2024
5tran-alexil
left a comment
5tran-alexil
left a comment
Contributor
There was a problem hiding this comment.
LGTM with a series if edits
ediril
approved these changes
Jun 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://fivetran.height.app/T-724858
Description
Added history mode guide