Clarify test recommendations#3
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the README guidance around when to write conversion-specific tests for the proto conversion library, aiming to reduce redundant low-level tests and emphasize relying on higher-level coverage.
Changes:
- Rewrites the “Test recommendations” section to recommend relying on higher-level tests that exercise
convert(). - Adds a note that conversion-specific tests may still be useful when custom conversion logic is hard to test via higher-level paths.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mdepinet
marked this pull request as ready for review
April 16, 2026 16:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.