Draft
Conversation
improve dependency description of docs
fix typo in environment variable reference
Remove cuDNN overhead
[backport] improve dependency description of docs
[backport] fix typo in environment variable reference
add test for argmin/argmax tie
[backport] add test for argmin/argmax tie
fix to correctly display filename of CUDA dump
[backport] fix to correctly display filename of CUDA dump
Add docs for missing argument
[backport] Add docs for missing argument
Fix stack function bug
[backport]Fix stack function bug
add pytest cache directory to gitignore
[backport] add pytest cache directory to gitignore
fix test to pass with numpy 1.9
Expose signatures to Reference
fix ElementwiseKernel.__call__ docs
[backport] fix ElementwiseKernel.__call__ docs
[backport] fix test to pass with numpy 1.9
Allow derived errors to pass equality tests
[backport] Expose signatures to Reference
Add default casting option to ufunc
fix wrong comment in test helper
[backport] Allow derived errors to pass equality tests
[backport] Add default casting option to ufunc
Fix matmul to raise ValueError on invalid shapes
[backport] Remove cuDNN overhead
[backport] fix wrong comment in test helper
[backport] Fix matmul to raise ValueError on invalid shapes
Fix matmul test for old NumPy
[backport] Fix matmul test for old NumPy
Cast CUPY_SEED environment variable to uint64
[backport] Cast CUPY_SEED environment variable to uint64
Remove dtype option which is introduced in v1.11
[backport]Remove dtype option which is introduced in v1.11
Fix: RandomState.choice reproducibility
[backport] Fix: RandomState.choice reproducibility
Update to v2.2.0
Conflicts: .gitignore clpy/core/core.pxd clpy/core/core.pyx clpy/core/elementwise.pxi clpy/cudnn.py clpy/manipulation/join.py clpy/random/generator.py clpy/random/sample.py clpy/testing/helper.py cupy/_version.py cupy_setup_build.py docker/python2/Dockerfile docker/python3/Dockerfile tests/clpy_tests/manipulation_tests/test_join.py tests/clpy_tests/random_tests/test_generator.py tests/clpy_tests/sorting_tests/test_search.py tests/clpy_tests/testing_tests/test_helper.py tests/cupy_tests/test_cudnn.py
jenkins-maekawa
suggested changes
Mar 3, 2020
jenkins-maekawa
left a comment
There was a problem hiding this comment.
Test (commit 94e35f2) failed on titanv.
============================= test session starts ==============================
platform linux -- Python 3.6.5, pytest-4.3.0, py-1.8.1, pluggy-0.13.1
rootdir: /home/clpy-jenkins-slave/workspace/clpy_testing_titan, inifile: setup.cfg
collected 159 items
test_distributions.py ........ [ 5%]
test_generator.py ...................................................... [ 38%]
.......................................F................... [ 76%]
test_permutations.py .... [ 78%]
test_random.py . [ 79%]
test_sample.py ................................. [100%]
=================================== FAILURES ===================================
______________________ TestChoiceChi.test_goodness_of_fit ______________________
../../../clpy/testing/condition.py:75: in wrapper
fail()
../../../clpy/testing/condition.py:52: in fail
instance.fail(msg)
E AssertionError:
E Fail: 1, Success: 0
E
E The first error message:
E Traceback (most recent call last):
E File "/home/clpy-jenkins-slave/workspace/clpy_testing_titan/clpy/testing/condition.py", line 61, in <lambda>
E lambda: f(ins, *args[1:], **kwargs),
E File "/home/clpy-jenkins-slave/workspace/clpy_testing_titan/tests/clpy_tests/random_tests/test_generator.py", line 410, in test_goodness_of_fit
E self.assertTrue(hypothesis.chi_square_test(counts, expected))
E AssertionError: False is not true
==================== 1 failed, 158 passed in 26.93 seconds =====================
jenkins-maekawa
suggested changes
Mar 3, 2020
jenkins-maekawa
left a comment
There was a problem hiding this comment.
Test (commit 94e35f2) failed on vega.
============================= test session starts ==============================
platform linux -- Python 3.6.5, pytest-4.3.0, py-1.8.1, pluggy-0.13.1
rootdir: /home/clpy-jenkins-slave/workspace/clpy_testing_vega, inifile: setup.cfg
collected 159 items
test_distributions.py ........ [ 5%]
test_generator.py ...................................................... [ 38%]
.......................................F................... [ 76%]
test_permutations.py .... [ 78%]
test_random.py . [ 79%]
test_sample.py ................................. [100%]
=================================== FAILURES ===================================
______________________ TestChoiceChi.test_goodness_of_fit ______________________
../../../clpy/testing/condition.py:75: in wrapper
fail()
../../../clpy/testing/condition.py:52: in fail
instance.fail(msg)
E AssertionError:
E Fail: 1, Success: 0
E
E The first error message:
E Traceback (most recent call last):
E File "/home/clpy-jenkins-slave/workspace/clpy_testing_vega/clpy/testing/condition.py", line 61, in <lambda>
E lambda: f(ins, *args[1:], **kwargs),
E File "/home/clpy-jenkins-slave/workspace/clpy_testing_vega/tests/clpy_tests/random_tests/test_generator.py", line 410, in test_goodness_of_fit
E self.assertTrue(hypothesis.chi_square_test(counts, expected))
E AssertionError: False is not true
==================== 1 failed, 158 passed in 37.55 seconds =====================
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#33 trial cupy/cupy@v2.1.0.1...v2.2.0
For participants: Github automatically adds original (CuPy) committers as this PR's participants, and no way is provided to avoit it. Sorry for disturbing you and please ignore the notification.