-
-
Notifications
You must be signed in to change notification settings - Fork 9
cache file descriptor #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v2
Are you sure you want to change the base?
Conversation
Although we mentioned using BufReader instead of File in #9, I think that File is just enough abstraction to hold the file descriptor. Caching BufReader limits how we want to use the file descriptor (i.e. maybe we use something else instead of BufReader next time). |
Also when using a |
Got it, let me check this out |
Probably should add a simple test for the FdCache (hit, no hit) |
Agree, I will follow up on this |
Added the test in |
solves #9