Skip to content

pre-commit fixes#1463

Open
jstucke wants to merge 2 commits intomasterfrom
remove-deprecated-pre-commit-check
Open

pre-commit fixes#1463
jstucke wants to merge 2 commits intomasterfrom
remove-deprecated-pre-commit-check

Conversation

@jstucke
Copy link
Collaborator

@jstucke jstucke commented Mar 24, 2026

  • removed ruff annotation and assert rules from test files (so that missing type hints and asserts in tests don't cause the CI to fail)
  • removed deprecated pre-commit check
    • The accompanying error (see below) suggested pyupgrade as a replacement, but since that is already included in ruff, we will just remove the check.
fix python encoding pragma (removed).....................................Failed
- hook id: fix-encoding-pragma
- exit code: 1

`fix-encoding-pragma` has been removed -- use `pyupgrade` from https://github.com/asottile/pyupgrade

the accompanying error suggested pyupgrade as a replacement but since that is already included in ruff we will just remove the check
@jstucke jstucke requested a review from dorpvom March 24, 2026 10:40
@jstucke jstucke self-assigned this Mar 24, 2026
@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.50%. Comparing base (52b8198) to head (9068b34).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1463      +/-   ##
==========================================
+ Coverage   92.40%   92.50%   +0.09%     
==========================================
  Files         370      370              
  Lines       20829    20800      -29     
==========================================
- Hits        19248    19241       -7     
+ Misses       1581     1559      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jstucke jstucke changed the title chore: removed deprecated pre-commit check pre-commit fixes Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants