Skip to content

Better shutdown - #1513

Open
jstucke wants to merge 4 commits into
masterfrom
better-shutdown
Open

Better shutdown#1513
jstucke wants to merge 4 commits into
masterfrom
better-shutdown

Conversation

@jstucke

@jstucke jstucke commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator
  • problem: many process in FACT are not properly joined/waited upon after termination
    • this means that the processes are not cleaned up correctly which can lead to zombie processes
    • merges the process termination functions in helper.process into one function
  • adds a unified config variable for graceful shutdown timeout
    • for tests, this shutdown time is reduced, which can lead to a significant test speedup
  • parallelizes shutdown of backend components and plugin runners

@jstucke jstucke self-assigned this Jul 27, 2026
@jstucke
jstucke force-pushed the better-shutdown branch 3 times, most recently from 6e0e5ba to 809a301 Compare July 28, 2026 13:40
@codecov-commenter

codecov-commenter commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.63265% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.59%. Comparing base (2c3bdae) to head (e27c271).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/helperFunctions/process.py 77.58% 13 Missing ⚠️
src/start_fact_backend.py 55.55% 4 Missing ⚠️
src/scheduler/analysis/plugin.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1513      +/-   ##
==========================================
- Coverage   93.08%   92.59%   -0.50%     
==========================================
  Files         375      368       -7     
  Lines       23566    21313    -2253     
==========================================
- Hits        21936    19734    -2202     
+ Misses       1630     1579      -51     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jstucke
jstucke marked this pull request as ready for review July 28, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants