fix: allow None as valid input via add in generic_adder - #1010
Open
Pablu23 wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1010 +/- ##
==========================================
- Coverage 93.16% 93.15% -0.02%
==========================================
Files 234 234
Lines 16070 16086 +16
==========================================
+ Hits 14972 14985 +13
- Misses 1098 1101 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mhoff
reviewed
Aug 10, 2026
mhoff
reviewed
Aug 10, 2026
Pablu23
force-pushed
the
feat-generic-adder-add-field-value
branch
from
August 10, 2026 08:14
09ee9c2 to
f5f812a
Compare
mhoff
reviewed
Aug 10, 2026
Collaborator
|
And please update the PR description. Then we are ready to go |
Pablu23
force-pushed
the
feat-generic-adder-add-field-value
branch
2 times, most recently
from
August 10, 2026 16:18
5a02677 to
f2c2486
Compare
mhoff
reviewed
Aug 11, 2026
mhoff
reviewed
Aug 11, 2026
Pablu23
force-pushed
the
feat-generic-adder-add-field-value
branch
from
August 11, 2026 16:10
f2c2486 to
88d25b3
Compare
mhoff
reviewed
Aug 12, 2026
Pablu23
force-pushed
the
feat-generic-adder-add-field-value
branch
2 times, most recently
from
August 12, 2026 08:47
9acd769 to
ce88693
Compare
mhoff
reviewed
Aug 12, 2026
Pablu23
force-pushed
the
feat-generic-adder-add-field-value
branch
from
August 12, 2026 10:56
ce88693 to
c071100
Compare
mhoff
approved these changes
Aug 12, 2026
mhoff
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. I have checked the preview box as it looks fine and your patch coverage is > 95% ("All modified and coverable lines are covered by tests.")
generic_adder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
generic_adder: allow None as valid input via
addAssignee
Documentation
Code Quality
How did you verify that the changes work in practice?
Reviewer
The rendered docs for this PR can be found here.
The rendered docs for this PR can be found here.