Skip to content

fix: allow None as valid input via add in generic_adder - #1010

Open
Pablu23 wants to merge 1 commit into
mainfrom
feat-generic-adder-add-field-value
Open

fix: allow None as valid input via add in generic_adder#1010
Pablu23 wants to merge 1 commit into
mainfrom
feat-generic-adder-add-field-value

Conversation

@Pablu23

@Pablu23 Pablu23 commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Description

generic_adder: allow None as valid input via add

Assignee

  • The changes adhere to the contribution guidelines
  • I have performed a self-review of my code
  • My changes generate no new warnings (e.g. flake8/mypy/pytest/...) other than deprecations

Documentation

Code Quality

  • Patch test coverage > 95% and does not decrease
  • New code uses correct & specific type hints

How did you verify that the changes work in practice?

  • Tests

Reviewer


The rendered docs for this PR can be found here.


The rendered docs for this PR can be found here.

@Pablu23
Pablu23 requested a review from mhoff August 7, 2026 12:56
@Pablu23 Pablu23 self-assigned this Aug 7, 2026
@codecov-commenter

codecov-commenter commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.15%. Comparing base (ce970b7) to head (c071100).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1010      +/-   ##
==========================================
- Coverage   93.16%   93.15%   -0.02%     
==========================================
  Files         234      234              
  Lines       16070    16086      +16     
==========================================
+ Hits        14972    14985      +13     
- Misses       1098     1101       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread logprep/processor/generic_adder/rule.py
Comment thread logprep/util/helper.py
@Pablu23
Pablu23 force-pushed the feat-generic-adder-add-field-value branch from 09ee9c2 to f5f812a Compare August 10, 2026 08:14
Comment thread logprep/processor/generic_adder/processor.py
@mhoff

mhoff commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

And please update the PR description. Then we are ready to go

@Pablu23
Pablu23 force-pushed the feat-generic-adder-add-field-value branch 2 times, most recently from 5a02677 to f2c2486 Compare August 10, 2026 16:18
Comment thread tests/unit/util/test_helper.py Outdated
Comment thread tests/unit/processor/generic_adder/test_generic_adder.py Outdated
@Pablu23
Pablu23 force-pushed the feat-generic-adder-add-field-value branch from f2c2486 to 88d25b3 Compare August 11, 2026 16:10
Comment thread tests/unit/processor/generic_adder/test_generic_adder.py Outdated
@Pablu23
Pablu23 force-pushed the feat-generic-adder-add-field-value branch 2 times, most recently from 9acd769 to ce88693 Compare August 12, 2026 08:47
Comment thread tests/unit/util/test_helper.py Outdated
@Pablu23
Pablu23 force-pushed the feat-generic-adder-add-field-value branch from ce88693 to c071100 Compare August 12, 2026 10:56

@mhoff mhoff left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have checked the preview box as it looks fine and your patch coverage is > 95% ("All modified and coverable lines are covered by tests.")

@mhoff mhoff changed the title feat: make GenericAdder "add" use FieldValue fix: make GenericAdder "add" use FieldValue Aug 12, 2026
@mhoff mhoff changed the title fix: make GenericAdder "add" use FieldValue fix: allow None as valid input via add in generic_adder Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants