add pipeline support#167
Closed
yuejiewang wants to merge 2 commits into
Closed
Conversation
yuejiewang
force-pushed
the
pipeline
branch
2 times, most recently
from
e622a84 to
17882cb
Compare
MC952-arch
reviewed
May 29, 2025
| clusterOffset * sendCount_, clusterOffset * sendCount_, | ||
| comm_->cluster_sizes[i] * sendCount_, 2, postHomoFuncCommOp); | ||
| if (nsteps_ > 1) { | ||
| size_t step = comm_->cluster_ids[i] + comm_->nclusters - clusterId_; |
MC952-arch
reviewed
May 29, 2025
| clusterInterRankList_[clusterId_][0] - (rank_ - homoMyRank_), | ||
| clusterOffset * sendCount_, clusterOffset * sendCount_, | ||
| comm_->cluster_sizes[i] * sendCount_, 2, postHomoFuncCommOp); | ||
| if (nsteps_ > 1) { |
Collaborator
There was a problem hiding this comment.
nsteps_可以设为成员变量，nSteps_
MC952-arch
reviewed
May 29, 2025
| comm_->nclusters; | ||
| postHomoFuncPipeline_[step].emplace_back( | ||
| clusterInterRankList_[clusterId_][i] - (rank_ - homoMyRank_), | ||
| it->offset_, it->offset_, it->count_, 0, postHomoFuncCommOp); |
MC952-arch
reviewed
May 29, 2025
| postHomoFuncPipeline_[step].emplace_back( | ||
| clusterInterRankList_[clusterId_][0] - (rank_ - homoMyRank_), | ||
| clusterOffset * sendCount_, clusterOffset * sendCount_, | ||
| comm_->cluster_sizes[i] * sendCount_, 0, postHomoFuncCommOp); |
yuejiewang
force-pushed
the
pipeline
branch
3 times, most recently
from
f1de3d4 to
0d7788f
Compare
* cluster-level pipelined ring allgather * use different streams for het and hom operations * adjust cost model (w/o pipeline)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pipeline only tested with ring allgather;
cost model is modified based on single-step operations.