[CRL] Store winFlags in flagcxWindow to fix non-NVIDIA build failure#488
Merged
MC952-arch merged 1 commit intoJun 2, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a non-NVIDIA build failure by persisting winFlags in the internal flagcxWindow object, avoiding reliance on vendor-specific flagcxInnerWindow fields that may not exist for non-NVIDIA adaptors.
Changes:
- Add
winFlagstostruct flagcxWindowand initialize it on the symmetric-heap (default) window path. - Store
winFlagson successful vendor window registration paths. - Update
flagcxDevMemCreateto derive symmetry fromwin->winFlagsinstead ofwin->vendorBase->winFlags.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
flagcx/flagcx.cc |
Stores winFlags into flagcxWindow when vendor window registration succeeds (including DevComm staged windows). |
flagcx/core/sym_heap.cc |
Initializes w->winFlags for symmetric-heap (default) windows. |
flagcx/core/include/sym_heap.h |
Extends internal flagcxWindow definition with a winFlags field. |
flagcx/adaptor/flagcx_device.cc |
Uses win->winFlags to determine symmetric behavior for vendor windows, removing dependency on vendor window layout. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
CRL
PR Types
Bug Fixes
PR Description