Skip to content

[CRL] Store winFlags in flagcxWindow to fix non-NVIDIA build failure#488

Merged
MC952-arch merged 1 commit into
flagos-ai:mainfrom
MC952-arch:fix-non-nvidia-build-failure
Jun 2, 2026
Merged

[CRL] Store winFlags in flagcxWindow to fix non-NVIDIA build failure#488
MC952-arch merged 1 commit into
flagos-ai:mainfrom
MC952-arch:fix-non-nvidia-build-failure

Conversation

@MC952-arch

Copy link
Copy Markdown
Collaborator

PR Category

CRL

PR Types

Bug Fixes

PR Description

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a non-NVIDIA build failure by persisting winFlags in the internal flagcxWindow object, avoiding reliance on vendor-specific flagcxInnerWindow fields that may not exist for non-NVIDIA adaptors.

Changes:

  • Add winFlags to struct flagcxWindow and initialize it on the symmetric-heap (default) window path.
  • Store winFlags on successful vendor window registration paths.
  • Update flagcxDevMemCreate to derive symmetry from win->winFlags instead of win->vendorBase->winFlags.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
flagcx/flagcx.cc Stores winFlags into flagcxWindow when vendor window registration succeeds (including DevComm staged windows).
flagcx/core/sym_heap.cc Initializes w->winFlags for symmetric-heap (default) windows.
flagcx/core/include/sym_heap.h Extends internal flagcxWindow definition with a winFlags field.
flagcx/adaptor/flagcx_device.cc Uses win->winFlags to determine symmetric behavior for vendor windows, removing dependency on vendor window layout.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@yuejiewang yuejiewang left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikethegoblin mikethegoblin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MC952-arch MC952-arch merged commit 4d50508 into flagos-ai:main Jun 2, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants