[CRL] Bootstrap extension

[MC952-arch]

PR Category

CRL

PR Types

New Features

PR Description

This PR extends the bootstrap layer to support a new P2P mode (RPC-style listen/connect/accept) alongside the existing collective/ring bootstrap, and wires that into the IB P2P engine so control-plane metadata + descriptor-table exchange can occur over a bootstrap socket rather than over the IB data socket.

[Copilot]

Pull request overview

This PR extends the bootstrap layer to support a new P2P mode (RPC-style listen/connect/accept) alongside the existing collective/ring bootstrap, and wires that into the IB P2P engine so control-plane metadata + descriptor-table exchange can occur over a bootstrap socket rather than over the IB data socket.

Changes:

• Introduces bootstrapState mode-dispatch (COLL vs P2P), adds P2P listen/connect/accept APIs, and adds bootstrap accessor APIs (rank/nranks + net context).
• Refactors collective bootstrap APIs into bootstrapColl* entrypoints and updates a broad set of call sites to use them.
• Updates the P2P engine handshake to use bootstrap P2P for handle/meta/descriptor-table exchange; adds new unit tests for bootstrap accessors and P2P RPC engine behavior.

Reviewed changes

Copilot reviewed 33 out of 33 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
test/unittest/p2p/test_p2p_engine_rpc.cpp	Adds unit tests for P2P engine RPC/bootstrap integration and handshake behaviors.
test/unittest/core/test_bootstrap_accessors.cpp	Adds unit tests for new bootstrap accessor APIs and bootstrapNetInit() behavior.
flagcx/service/include/bootstrap.h	Adds bootstrap mode/types, splits collective APIs into bootstrapColl*, adds P2P APIs + accessor APIs, updates typed-collective signatures.
flagcx/service/bootstrap.cc	Implements accessor APIs, refactors collective init/ops, adds unified send/recv/exchange/close dispatch, and implements bootstrap P2P listen/connect/accept.
flagcx/flagcx.cc	Updates collective bootstrap usage to new bootstrapColl* APIs and uses accessors for net properties.
flagcx/core/topo.cc	Switches topo exchange barriers/allgathers to bootstrapColl*.
flagcx/core/sym_heap.cc	Switches intra-node barriers to bootstrapCollIntraNodeBarrier.
flagcx/core/proxy.cc	Switches proxy peer address allgather to bootstrapCollAllGather.
flagcx/core/init.cc	Switches init allgather/barrier to bootstrapColl* and uses bootstrapCollInit for bootstrap state creation.
flagcx/core/include/topo.h	Types bootstrap field as struct bootstrapState*.
flagcx/core/include/global_comm.h	Types bootstrap field as struct bootstrapState*.
flagcx/core/flagcx_tuner.cc	Switches tuner sync to bootstrapColl* and types bootstrap pointer.
flagcx/core/flagcx_p2p.cc	Integrates bootstrap P2P into P2P engine control-plane handshake; exposes bootstrap listen port as “RPC port”.
flagcx/adaptor/include/mpi_adaptor.h	Updates bootstrap pointer types to struct bootstrapState*.
flagcx/adaptor/include/gloo_adaptor.h	Switches to bootstrapColl* for coordination and updates bootstrap pointer types.
flagcx/adaptor/include/flagcx_ccl_adaptor.h	Updates adaptor API signature bootstrap pointer type to struct bootstrapState*.
flagcx/adaptor/include/bootstrap_adaptor.h	Updates stored bootstrap pointer type to struct bootstrapState*.
flagcx/adaptor/flagcx_device.cc	Switches IPC bootstrap sync to bootstrapColl*.
flagcx/adaptor/ccl/xccl_adaptor.cc	Updates bootstrap pointer type in init signature.
flagcx/adaptor/ccl/tccl_adaptor.cc	Updates bootstrap pointer type in init signature.
flagcx/adaptor/ccl/rccl_adaptor.cc	Updates bootstrap pointer type in init signature.
flagcx/adaptor/ccl/pccl_adaptor.cc	Updates bootstrap pointer type in init signature.
flagcx/adaptor/ccl/nccl_adaptor.cc	Updates bootstrap pointer type in init signature.
flagcx/adaptor/ccl/musa_mccl_adaptor.cc	Updates bootstrap pointer type in init signature.
flagcx/adaptor/ccl/mpi_adaptor.cc	Updates bootstrap pointer type in init signature.
flagcx/adaptor/ccl/mccl_adaptor.cc	Updates bootstrap pointer type in init signature.
flagcx/adaptor/ccl/ixnccl_adaptor.cc	Updates bootstrap pointer type in init signature.
flagcx/adaptor/ccl/hccl_adaptor.cc	Updates bootstrap pointer type in init signature.
flagcx/adaptor/ccl/gloo_adaptor.cc	Switches from bootstrap-state-owned net props/ifname to new accessor APIs.
flagcx/adaptor/ccl/eccl_adaptor.cc	Updates bootstrap pointer type in init signature.
flagcx/adaptor/ccl/dunccl_adaptor.cc	Updates bootstrap pointer type in init signature.
flagcx/adaptor/ccl/cncl_adaptor.cc	Updates bootstrap pointer type in init signature.
flagcx/adaptor/ccl/bootstrap_adaptor.cc	Uses accessor APIs for rank/nranks instead of direct struct fields; updates bootstrap pointer type.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 33 out of 33 changed files in this pull request and generated 7 comments.

[Copilot]

Pull request overview

Copilot reviewed 33 out of 33 changed files in this pull request and generated 6 comments.