Support hipprof step profiling#1234
Open
lihongyang1990 wants to merge 9 commits into
Open
Conversation
lihongyang1990
requested review from
aoyulong,
heavyrain-lzy and
zhaoyinglia
as code owners
lihongyang1990
force-pushed
the
hipprof-step-profile
branch
from
41d0ff8 to
8e853d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
Train | Hardware | Tools
PR Types
New Features | Improvements
PR Description
Add hipprof session-based profiling support for training so DCU runs can use
profile_step_startandprofile_step_endto control the profilingwindow.
Changes:
use_hipprof_profiler,hipprof_bin_path, andhipprof_session_idprofiling options.PYTHON_EXECwrapper script that attaches hipprof to selected torchrun worker ranks and exports the session id for in-process start/stopcontrol.
Validation:
pre-commit run --files flagscale/train/megatron/training/config/common_config.py flagscale/train/megatron/training/training.py tools/ profiling/hipprof_python_wrapper.shbash -n tools/profiling/hipprof_python_wrapper.shRuntime hipprof validation still needs to be run on the target DCU server.