Skip to content

[BUILD] Fix git submodule update init for triton_v3.3.x (#260) #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhzhcookie merged 1 commit into from
Dec 31, 2025
Merged

[BUILD] Fix git submodule update init for triton_v3.3.x (#260) #263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions python/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,21 +50,29 @@ class BackendInstaller:

@staticmethod
def prepare(backend_name: str, backend_src_dir: str = None, is_external: bool = False):
dir_mapping = {"mlu": "cambricon"}
actual_dir_name = dir_mapping.get(backend_name, backend_name)
# Initialize submodule if there is one for in-tree backends.
if not is_external:
root_dir = os.path.join(os.pardir, "third_party")
assert backend_name in os.listdir(
root_dir), f"{backend_name} is requested for install but not present in {root_dir}"
assert actual_dir_name in os.listdir(
root_dir), f"{actual_dir_name} is requested for install but not present in {root_dir}"

try:
subprocess.run(["git", "submodule", "update", "--init", f"{backend_name}"], check=True,
stdout=subprocess.DEVNULL, cwd=root_dir)
# flagtree: check if the submodule is defined in .gitmodules
check_result = subprocess.run(
["git", "config", "-f", ".gitmodules", "--get-regexp", f"submodule.*{actual_dir_name}.path"],
check=False, stdout=subprocess.PIPE, stderr=subprocess.DEVNULL, cwd=os.pardir)
# flagtree: only execute git submodule update for actual git submodules
if check_result.returncode == 0:
subprocess.run(["git", "submodule", "update", "--init", f"{actual_dir_name}"], check=True,
stdout=subprocess.DEVNULL, cwd=root_dir)
except subprocess.CalledProcessError:
pass
except FileNotFoundError:
pass

backend_src_dir = os.path.join(root_dir, backend_name)
backend_src_dir = os.path.join(root_dir, actual_dir_name)

backend_path = os.path.abspath(os.path.join(backend_src_dir, "backend"))
assert os.path.exists(backend_path), f"{backend_path} does not exist!"
Expand All @@ -80,7 +88,7 @@ def prepare(backend_name: str, backend_src_dir: str = None, is_external: bool =
for file in ["compiler.py", "driver.py"]:
assert os.path.exists(os.path.join(backend_path, file)), f"${file} does not exist in ${backend_path}"

install_dir = os.path.join(os.path.dirname(__file__), "triton", "backends", backend_name)
install_dir = os.path.join(os.path.dirname(__file__), "triton", "backends", actual_dir_name)
package_data = [f"{os.path.relpath(p, backend_path)}/*" for p, _, _, in os.walk(backend_path)]

language_package_data = []
Expand Down
Loading