[CICD] Upload unittest coverage report to FlagCICD platform & Use BAAI runner#28
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances the shared unit test reusable workflow by generating a Python coverage JSON report per test-group run and uploading it both as a GitHub Actions artifact and to the FlagCICD platform. It also updates the Metax runner label to target the new CI node.
Changes:
- Added a
upload_coverageworkflow input (defaulttrue) to control coverage generation/upload. - Wrapped the
torchrunpytest execution withcoveragecollection and post-processing to a JSON report incoverage-report/. - Uploaded the coverage report as an artifact and posted it to FlagCICD; updated Metax runner label to
mx-4g-cicd-test.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/unit_tests_common.yml | Adds coverage generation, artifact upload, and FlagCICD upload steps to the common unit test workflow. |
| .github/configs/metax.yml | Updates Metax runner label configuration to use the new runner label. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Darryl233
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds coverage report collection and upload functionality to the common unit test workflow (
unit_tests_common.yml), and updates the MetaX runner label to match the new CI node.Type of change
Changes
Run unit testsstep: wraps thetorchruninvocation withcoverage run --parallel, then runscoverage combine+coverage jsonafter tests complete, outputting results tocoverage-report/Upload Coverage Reportstep to save the JSON report as a CI artifact viaactions/upload-artifact@v4Upload Coverage Report to FlagCICDstep that callsflagos-ai/FlagOps/actions/post-pytest-report@v2to push coverage data to the FlagCICD platform.github/configs/metax.ymltomx-4g-cicd-testChecklist: