[CICD] Upload unittest coverage report to FlagCICD platform && Access FlagCICD runner#58
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the unit test CI workflow to generate and upload a per-test-group Python coverage JSON report, and removes some leftover/unused CI config lines.
Changes:
- Consolidates coverage setup + coverage JSON generation into the
Execute Testsstep (gated totest_type == unittest). - Renames coverage artifacts/reports to include
matrix.test_group.nameto avoid collisions. - Cleans up CUDA runner config by removing commented-out container volume entries.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.github/workflows/unit_tests_common.yml |
Refactors coverage generation, adjusts artifact naming, and uploads the report to FlagCICD. |
.github/configs/cuda.yml |
Removes commented-out container volume lines. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aoyulong
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simplifies and consolidates the coverage report generation logic in the CI unittest workflow, reducing redundant steps and dependencies.
Need to test uploading reports to FlagCICD step in CI env.
Type of change
Changes
Generate Coverage Reportinto theExecute Testsstep — coveragecombineandjsongeneration now run inline afterbash test.sh, following the same pattern as Megatron-LM-FLtest_type == 'unittest'to avoid running for lint/debug groups, andpip installis done only oncefetch-depth: 0from checkout steps (not required for unit test runs)TODO
Checklist: