Skip to content

[CICD] Upload unittest coverage report to FlagCICD platform && Access FlagCICD runner#58

Merged
Darryl233 merged 24 commits into
flagos-ai:mainfrom
BrianPei:coverage-0402
Apr 9, 2026
Merged

[CICD] Upload unittest coverage report to FlagCICD platform && Access FlagCICD runner#58
Darryl233 merged 24 commits into
flagos-ai:mainfrom
BrianPei:coverage-0402

Conversation

@BrianPei

@BrianPei BrianPei commented Apr 2, 2026

Copy link
Copy Markdown
Collaborator

Description

Simplifies and consolidates the coverage report generation logic in the CI unittest workflow, reducing redundant steps and dependencies.
Need to test uploading reports to FlagCICD step in CI env.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Infra/Build change (changes to CI/CD workflows or build scripts)
  • Code refactoring
  • Documentation change
  • Bug fix
  • Breaking change

Changes

  • Merged Generate Coverage Report into the Execute Tests step — coverage combine and json generation now run inline after bash test.sh, following the same pattern as Megatron-LM-FL
  • Coverage collection is gated on test_type == 'unittest' to avoid running for lint/debug groups, and pip install is done only once
  • Removed fetch-depth: 0 from checkout steps (not required for unit test runs)
  • Removed unused/leftover scripts from the repository

TODO

Checklist:

  • I have read and followed the contributing guidelines.
  • The functionality is complete
  • I have commented my code, particularly in coverage report uploading steps
  • My changes generate no new warnings
  • I have added/updated tests that prove my feature works on Cuda and Metax platform.
  • New and existing unit tests pass locally on Cuda and Metax platform.

Copilot AI review requested due to automatic review settings April 2, 2026 09:06

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the unit test CI workflow to generate and upload a per-test-group Python coverage JSON report, and removes some leftover/unused CI config lines.

Changes:

  • Consolidates coverage setup + coverage JSON generation into the Execute Tests step (gated to test_type == unittest).
  • Renames coverage artifacts/reports to include matrix.test_group.name to avoid collisions.
  • Cleans up CUDA runner config by removing commented-out container volume entries.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/unit_tests_common.yml Refactors coverage generation, adjusts artifact naming, and uploads the report to FlagCICD.
.github/configs/cuda.yml Removes commented-out container volume lines.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/unit_tests_common.yml
Comment thread .github/workflows/unit_tests_common.yml
Comment thread .github/workflows/unit_tests_common.yml
@Darryl233 Darryl233 changed the title [wip] Upload unittest coverage report to FlagCICD platform Upload unittest coverage report to FlagCICD platform Apr 9, 2026
@Darryl233 Darryl233 changed the title Upload unittest coverage report to FlagCICD platform [CICD] Upload unittest coverage report to FlagCICD platform && Access FlagCICD runner Apr 9, 2026

@Darryl233 Darryl233 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Darryl233 Darryl233 merged commit 9d1c48a into flagos-ai:main Apr 9, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants