-
Notifications
You must be signed in to change notification settings - Fork 28
[CICD] Improve CUDA unit test coverage #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 16 commits
56dbf6c
4c9497d
8087e46
0816a90
5ea7f59
6980c22
71cd45b
e45fa19
dcedc67
0781d16
d2891db
e54ea9c
6ee3ffa
8017d84
7451d1b
cea6119
13bea00
ddeca96
26f5dd1
20ab8ab
cb87eda
e2ee1e3
07b4519
eda3696
7334abb
f295e45
b39752d
fd97b28
f99e34b
2684dfd
c226063
74343fe
2eb27ab
5496ecb
d54837c
919eac7
a0becb8
1e56a54
2d2879d
69bd5f0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| # Moore Threads (MUSA) Hardware Configuration for TE-FL | ||
| # This file defines CI/CD settings for Moore Threads MUSA-based testing | ||
| # This file defines environment variables, volumes, and test filters for TE tests. | ||
|
|
||
| hardware_name: musa | ||
| display_name: 'Moore Threads MUSA Tests' | ||
|
|
||
| # CI image for Moore Threads env (Updated to the 0206 verified image) | ||
| ci_image: registry.mthreads.com/presale/devtech/flagsclae:0206 | ||
|
|
||
| # Target precise runner labels for the 140 Moore Threads node | ||
| runner_labels: | ||
| - mt-8g-cicd-te | ||
|
|
||
| # Container volumes | ||
| container_volumes: | ||
| - /data:/data | ||
|
|
||
| # Container options for MUSA execution | ||
| container_options: >- | ||
| --uts=host | ||
| --ipc=host | ||
| --privileged=true | ||
| --shm-size=32gb | ||
| --user root | ||
| --ulimit nofile=65535:65535 | ||
| --device=/dev/mtgpu | ||
| -e PLATFORM=musa | ||
| -e ACCELERATOR_BACKEND=musa | ||
| -e MUSA_VISIBLE_DEVICES=0 | ||
| -e TE_FL_PREFER=reference | ||
| -e LD_LIBRARY_PATH=/usr/local/musa/lib:/usr/local/lib:$LD_LIBRARY_PATH | ||
| -e http_proxy="http://flagcicd-yzli:A7fK9mQ2Zx4P@10.1.12.38:3128" | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please do not expose proxy settings in repo config
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'll remove the hardcoded proxy configuration from the repository and rely on the CI environment to provide the required proxy settings. |
||
| -e https_proxy="http://flagcicd-yzli:A7fK9mQ2Zx4P@10.1.12.38:3128" | ||
|
|
||
| # Platform-specific environment setup script | ||
| setup_script: .github/scripts/setup_musa.sh | ||
|
|
||
| # Build environment variables & Proxy Settings for CI Runner | ||
| build_env: | ||
| TE_FL_SKIP_CUDA: '1' | ||
| MUSA_HOME: /usr/local/musa | ||
| http_proxy: "http://flagcicd-yzli:A7fK9mQ2Zx4P@10.1.12.38:3128" | ||
| https_proxy: "http://flagcicd-yzli:A7fK9mQ2Zx4P@10.1.12.38:3128" | ||
|
|
||
| # Device types to run tests on | ||
| device_types: | ||
| - mt-gpu | ||
|
|
||
| # Test matrix configuration | ||
| test_matrix: | ||
| unit: | ||
| devices: | ||
| - mt-gpu | ||
| ignored_tests: | ||
| # - tests/pytorch/test_numerics.py | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If the MUSA workflow doesn't work currently, remove it from the PR.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've removed the MUSA workflow changes from this PR since it is not functional at the moment. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| name: musa_tests | ||
|
|
||
| on: | ||
| push: | ||
| branches: ["main"] | ||
| pull_request: | ||
| branches: ["main"] | ||
| workflow_dispatch: | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}-${{ github.actor }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| run_tests: | ||
| # Package manager and environment settings are read from .github/configs/musa.yml | ||
| uses: ./.github/workflows/all_tests_common.yml | ||
| with: | ||
| platform: musa | ||
| run_unit_tests: true | ||
| run_integration_tests: true | ||
|
|
||
| all_tests: | ||
| needs: run_tests | ||
| runs-on: ubuntu-latest | ||
| if: always() | ||
| steps: | ||
| - name: Verify workflow status | ||
| run: | | ||
| if [ "${{ needs.run_tests.result }}" != "success" ]; then | ||
| echo "❌ MUSA Tests workflow failed" | ||
| exit 1 | ||
| fi | ||
| echo "✅ All MUSA tests passed!" |
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are these output files necessary?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This file is generated during the integration test and is not required to be tracked. I'll remove it from the PR and add it to .gitignore if appropriate. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| {"sharded_backend": "torch_dist", "sharded_backend_version": 1, "common_backend": "torch", "common_backend_version": 1} |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary cache files have been cleared.