Skip to content

Support string constexpr kernel args; scope googletest to examples #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tengqm merged 1 commit into from
Jul 13, 2026
Merged

Support string constexpr kernel args; scope googletest to examples #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,13 +215,15 @@ add_subdirectory(src)
# ==============================================================================
# Examples
# ==============================================================================
set(INSTALL_GTEST OFF)
github_url(GTEST_URL "google/googletest/archive/refs/tags/v1.16.0.tar.gz")
FetchContent_Declare(googletest URL ${GTEST_URL} DOWNLOAD_EXTRACT_TIMESTAMP ON)
FetchContent_MakeAvailable(googletest)

option(TRITON_JIT_BUILD_EXAMPLES "Build examples" ${PROJECT_IS_TOP_LEVEL})
if(TRITON_JIT_BUILD_EXAMPLES)
# googletest is only needed by the examples; fetch it here so that
# subdirectory consumers (e.g. FlagGems via FetchContent) do not pull it in.
set(INSTALL_GTEST OFF)
github_url(GTEST_URL "google/googletest/archive/refs/tags/v1.16.0.tar.gz")
FetchContent_Declare(googletest URL ${GTEST_URL} DOWNLOAD_EXTRACT_TIMESTAMP ON)
FetchContent_MakeAvailable(googletest)

add_subdirectory(examples)
endif()

Expand Down
11 changes: 11 additions & 0 deletions include/triton_jit/triton_jit_function.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
#include <optional>
#include <sstream>
#include <string>
#include <string_view>
#include <type_traits>
#include <unordered_map>
#include <utility>
Expand Down Expand Up @@ -147,6 +148,16 @@ struct ArgHandle {
// Assumption: nullopt is always treated as constexpr,
// even if the parameter is not marked as constexpr
signature.push_back("nullopt");
} else if constexpr (std::is_same_v<std::decay_t<T>, const char*> ||
std::is_same_v<std::decay_t<T>, char*> ||
is_same_ignore_cvref<std::string, T>::value ||
is_same_ignore_cvref<std::string_view, T>::value) {
// A string argument (e.g. a dtype spelled "tl.float32") can only ever be
// a constexpr Triton parameter. Route it to handle_constexpr at compile
// time so the specialized / non-constexpr paths -- which require
// triton_type<T>::name and do not specialize for strings -- are never
// instantiated for a string type.
handle_constexpr(item);
} else {
if (ssig.at(idx) == ArgType::CONSTEXPR) { // constexpr
handle_constexpr(item);
Expand Down
Loading