Skip to content

Commit 845dcf5

Browse files
committed
clean code
1 parent bc0b685 commit 845dcf5

File tree

5 files changed

+7
-16
lines changed

5 files changed

+7
-16
lines changed

example/lib/widgets/configuration.dart

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -406,8 +406,7 @@ class _ConfigurationState extends State<Configuration> with ShowDialog {
406406
GestureBinding.instance.pointerRouter
407407
.addGlobalRoute(_emotionAIGlobalPointerRoute);
408408
} catch (e) {
409-
// Todo later add flagship logger
410-
print(e);
409+
Flagship.logger(Level.ERROR, e.toString());
411410
}
412411

413412
Flagship.sharedInstance()

lib/visitor.dart

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,7 @@ enum Instance {
4040
NEW_INSTANCE
4141
}
4242

43-
const Duration FSSessionVisitor = Duration(
44-
seconds:
45-
20); // redo later Duration(seconds: 1 * 60 * 30); // example 30 min
43+
const Duration FSSessionVisitor = Duration(seconds: 1 * 60 * 30); // 30 min
4644

4745
class Visitor with EmotionAiDelegate {
4846
/// VisitorId

lib/visitor/strategy/default_strategy.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ class DefaultStrategy implements IVisitor {
4242
Modification modification,
4343
bool isDuplicated,
4444
) async {
45-
// Getconfig et le callback
45+
// Get config and callback
4646
final config = Flagship.sharedInstance().getConfiguration();
4747
final onExposed = config?.onVisitorExposed;
4848

@@ -69,7 +69,7 @@ class DefaultStrategy implements IVisitor {
6969
exposedFlag.alreadyActivatedCampaign = true;
7070
onExposed(exposedVisitor, exposedFlag);
7171
}
72-
print('Skip the activate: Flag already activated.');
72+
Flagship.logger(Level.INFO, " The camapign's flag already activated ");
7373
return;
7474
}
7575

@@ -88,14 +88,14 @@ class DefaultStrategy implements IVisitor {
8888
visitorJson,
8989
);
9090

91-
// Log interne pour troubleshooting
91+
// Send troubleshooting
9292
DataUsageTracking.sharedInstance().processTroubleShootingHits(
9393
CriticalPoints.VISITOR_SEND_ACTIVATE.name,
9494
visitor,
9595
activateHit,
9696
);
9797

98-
// Envoi du hit
98+
// Send Activate hit
9999
try {
100100
final response = await visitor.trackingManager?.sendActivate(activateHit);
101101
final status = response?.statusCode ?? -1;

lib/visitor/strategy/not_ready_strategy.dart

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,6 @@ class NotReadyStrategy extends DefaultStrategy {
1717
return null;
1818
}
1919

20-
//@override
21-
// Future<void> activateModification(String key) async {
22-
// Flagship.logger(Level.ERROR, ACTIVATE_NOT_READY);
23-
//}
24-
2520
@override
2621
Future<void> activateFlag(Modification pFlag,
2722
{bool isDuplicated = false}) async {

lib/visitor/visitor_delegate.dart

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import 'package:flagship/visitor/strategy/no_consent_strategy.dart';
99
import 'package:flagship/visitor/strategy/not_ready_strategy.dart';
1010
import 'package:flagship/visitor/strategy/panic_strategy.dart';
1111
import 'package:flagship/flagship.dart';
12-
import 'package:flutter/material.dart';
1312
import '../visitor.dart';
1413

1514
class VisitorDelegate implements IVisitor {
@@ -141,7 +140,7 @@ class VisitorDelegate implements IVisitor {
141140
getStrategy().onAppScreenChange(screenName);
142141
}
143142

144-
/// Returns `true` if this (campId, varGrpId) pair is considered “deduplicated”.
143+
/// Returns `true` if flag is already activated during visitor session
145144
bool _isDeduplicatedFlag(String campId, String varGrpId) {
146145
final DateTime now = DateTime.now();
147146
final Duration elapsed = now.difference(visitor.sessionDuration);

0 commit comments

Comments
 (0)