clean code

Author: ABTastyAdel

lib/visitor.dart

@@ -81,6 +81,7 @@ class Visitor with EmotionAiDelegate {
   Map<String, dynamic> assignmentsHistory = {};
 
   /// Delegate visitor
+
   late VisitorDelegate _visitorDelegate;
 
   /// Delegate to update the status

lib/visitor/strategy/default_strategy.dart

@@ -22,10 +22,6 @@ import 'package:flagship/visitor/Ivisitor.dart';
 // This class represent the default behaviour
 class DefaultStrategy implements IVisitor {
   final Visitor visitor;
-
-  /// Stores the last variation-group id that was activated per campaign id.
-  //Map<String, String> _activatedVariations = {};
-
   DefaultStrategy(this.visitor);
 
   @override
@@ -42,63 +38,6 @@ class DefaultStrategy implements IVisitor {
     }
   }
 
-  // Activate
-  /*  Future<void> _sendActivate(
-      Modification pModification, bool isDuplicated) async {
-    // Check if the callback is defined
-    ExposedFlag? exposedFlag;
-    VisitorExposed? exposedVisitor;
-    if (Flagship.sharedInstance().getConfiguration()?.onVisitorExposed !=
-        null) {
-      exposedFlag = ExposedFlag(
-          pModification.key,
-          pModification.value,
-          pModification.defaultValue,
-          FlagMetadata.withMap(pModification.toJsonInformation()));
-
-      exposedVisitor = VisitorExposed(
-          visitor.visitorId, visitor.anonymousId, visitor.getContext());
-    }
-
-    // If deduplication we exit
-    if (isDuplicated) {
-      if (exposedFlag != null && exposedVisitor != null) {
-        // Update exposed flag
-        exposedFlag.alreadyActivatedCampaign = true;
-        Flagship.sharedInstance()
-            .getConfiguration()
-            ?.onVisitorExposed
-            ?.call(exposedVisitor, exposedFlag);
-      }
-
-      print("skip the activate .... since the flag is already activated ");
-      return;
-    }
-
-    // Build the activate hit
-    Activate activateHit = Activate(
-        pModification,
-        visitor.visitorId,
-        visitor.anonymousId,
-        Flagship.sharedInstance().envId ?? "",
-        jsonEncode(exposedFlag).toString(),
-        jsonEncode(exposedVisitor).toString());
-    // Process the troubleShooting
-    DataUsageTracking.sharedInstance().processTroubleShootingHits(
-        CriticalPoints.VISITOR_SEND_ACTIVATE.name, visitor, activateHit);
-
-    visitor.trackingManager?.sendActivate(activateHit).then((activateResponse) {
-      if (activateResponse.statusCode >= 200 &&
-          activateResponse.statusCode < 300) {
-      } else {
-        Flagship.logger(
-            Level.ERROR,
-            ACTIVATE_FAILED +
-                " status code = ${activateResponse.statusCode.toString()}");
-      }
-    });
-  } */
-
   Future<void> _sendActivate(
     Modification modification,
     bool isDuplicated,

test/activate_test.dart

@@ -24,7 +24,6 @@ import 'fake_path_provider_platform.dart';
 import 'test_tools.dart';
 import 'package:http/http.dart' as http;
 import 'service_test.mocks.dart';
-import 'test_tools.dart';
 
 @GenerateMocks([Service])
 void main() {
@@ -70,6 +69,7 @@ void main() {
       if (v.id == "expoVisitor") {
         expect(f.metadata().campaignId, "campaignId");
         expect(v.id, "expoVisitor");
+        expect(f.alreadyActivatedCampaign, false);
       }
     }).build();
     Flagship.start("bkk9glocmjcg0vtmdlrr", "apiKey", config: expoConfig);
@@ -178,5 +178,6 @@ void main() {
     var tr = dfltStrategy.visitor.trackingManager
         as TrackingManageContinuousStrategy;
     expect(tr.activatePool.fsQueue.length, 0);
+    dfltStrategy.onExposure(itemModif);
   });
 }