Deduplication flutter #55
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 4.1.2-beta #55 +/- ##
==============================================
- Coverage 76.57% 75.30% -1.28%
==============================================
Files 66 67 +1
Lines 2801 2867 +66
==============================================
+ Hits 2145 2159 +14
- Misses 656 708 +52
... and 15 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
ABTastyAdel
commented
Jul 28, 2025
| class FSData extends ChangeNotifier { | ||
| // Apikey | ||
| String _apiKey = "apiKey"; // | ||
| String _apiKey = "DxAcxlnRB9yFBZYtLDue1q01dcXZCw6aM49CQB23"; // |
Collaborator
Author
There was a problem hiding this comment.
remove the key
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
manage lookup visitor
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements flag activation deduplication to prevent redundant activation hits for the same campaign/variation during a visitor session, and includes various improvements to caching, authentication handling, and dependency updates.
- Adds session-based tracking (30 min) to deduplicate flag activations for the same campaign/variation group
- Implements selective visitor cache lookup logic to check anonymousId when visitorId doesn't exist
- Removes mode restrictions for authenticate/unauthenticate methods to work in both DECISION_API and BUCKETING modes
Reviewed Changes
Copilot reviewed 28 out of 31 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/visitor/visitor_delegate.dart | Implements deduplication logic tracking activated variations per session |
| lib/visitor/strategy/default_strategy.dart | Refactors activation logic to handle deduplicated flags and skip network requests |
| lib/visitor.dart | Adds sessionDuration tracking and visitor lookup optimization |
| lib/model/exposed_flag.dart | Adds alreadyActivatedCampaign field to track deduplicated activations |
| lib/cache/interface_cache.dart | Adds visitorExists method to check cache without data retrieval |
| lib/cache/default_cache.dart | Implements visitorExists with database query |
| lib/Storage/database_management.dart | Adds SQL query to check visitor existence |
| lib/decision/bucketing_manager.dart | Fixes assignment history to merge instead of clearing |
| pubspec.yaml | Updates package version to 4.2.0-beta |
| test/activate_test.dart | Adds comprehensive test for deduplication feature |
| test/tracking_manager_test.dart | Tests session expiration with manipulated sessionDuration |
| example/lib/widgets/configuration.dart | Fixes Mode comparison logic and improves error logging |
| example/lib/Providers/fs_data.dart | Updates example configuration values |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
|
Collaborator
Author
|
Already merged in 4.2.0-beta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.