Open
Conversation
MaxDall
requested changes
Mar 3, 2026
Collaborator
MaxDall
left a comment
MaxDall
left a comment
There was a problem hiding this comment.
@addie9800 Thanks a lot for updating the layout 👍
src/fundus/publishers/uk/nature.py
Outdated
|
|
||
| class V1_1(V1): | ||
| _paragraph_selector = XPath( | ||
| "//div[@data-test='main-content' or @class='main-content']//p" |
Collaborator
Collaborator
Author
There was a problem hiding this comment.
Thanks for catching, should be fixed now 👍
Collaborator
There was a problem hiding this comment.
@addie9800 Unfortunately the plaintext of 1 is now cut off.
Collaborator
Author
There was a problem hiding this comment.
@MaxDall Unfortunately, I cannot reproduce that. The last extracted sentence in my test is: It’s not crazy. It’s really exciting.” as expected. Or what do you mean by cut off?
Collaborator
There was a problem hiding this comment.
@addie9800 Hmm, that's weird. For me the last paragraph is the one before the Reinventing MRI subheadline, ending with “It’s a tiny change on a tiny scale.”
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, since the publisher coverage did not fail and archive constantly redirecting, I can't accurately place the valid_until date. We know for sure it didn't work since the release of v0.5.5 due to qse errors.