Skip to content

Use __EVENTS__.context() for main-thread #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MaxDall wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use __EVENTS__.context() for main-thread #891

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/fundus/scraping/crawler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,8 +247,6 @@ def __init__(self, *publishers: PublisherType):
if not self.publishers:
raise ValueError("param <publishers> of <Crawler.__init__> must include at least one publisher.")

__EVENTS__.alias("main-thread")

@abstractmethod
def _build_article_iterator(
self,
Expand Down Expand Up @@ -402,7 +400,9 @@ def callback() -> None:
callback = None

try:
with Timeout(seconds=timeout, silent=True, callback=callback, disable=timeout <= 0) as timer:
with __EVENTS__.context("main-thread"), Timeout(
seconds=timeout, silent=True, callback=callback, disable=timeout <= 0
) as timer:
for article in self._build_article_iterator(
tuple(fitting_publishers),
error_handling,
Expand Down Expand Up @@ -431,7 +431,6 @@ def callback() -> None:
break
finally:
session_handler.close_current_session()
__EVENTS__.reset()
if save_to_file is not None:
if isinstance(save_to_file, str):
save_to_file = Path(save_to_file)
Expand Down