Skip to content

Optionally confirm to quit after pressing Escape #3758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

y5c4l3
Copy link

@y5c4l3 y5c4l3 commented Oct 19, 2024

@y5c4l3
Copy link
Author

y5c4l3 commented Oct 21, 2024

In case that someone wants a demo:
Peek

@b0ch3nski
Copy link
Contributor

Thanks for implementing this! I found myself in many situations where I've marked up something on the screenshot and then accidentally quit editing it...

I've tested this and I can confirm that it's working as described.

@b0ch3nski
Copy link
Contributor

@borgmanJeremy @mmahmoudian please also take a look at this one 🙂 I have been using this PR along couple of others for a month now on my daily basis and I can confirm that it indeed gets the job done.

@mmahmoudian
Copy link
Member

mmahmoudian commented May 1, 2025

This also addresses #2055

The code is clean and looks good to me. Just as a very minor suggestion: maybe hardcoding the color can be changed to something dynamic to katch the overall theme that the user has configured?

Let's wait for other devs' approval.

@borgmanJeremy
Copy link
Collaborator

Thanks! looks good to me. Would you be able to rebase on master to trigger the CI? Then I can merge it.

@borgmanJeremy borgmanJeremy self-assigned this May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants