Skip to content

Respect disabledGrimWarning config all notifications #3896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Respect disabledGrimWarning config all notifications #3896

wants to merge 1 commit into from

Conversation

b0ch3nski
Copy link
Contributor

@b0ch3nski b0ch3nski commented Apr 1, 2025 •
edited
Loading

This change extends #3456 that missed this notification (which is kinda annoying for people who do not use grim intentionally).

@borgmanJeremy
Copy link
Collaborator

@b0ch3nski to fix the build errors you will need to rebase on the latest commits.

@b0ch3nski b0ch3nski force-pushed the grim-warning branch 2 times, most recently from b8eb5e5 to baf16ec Compare April 28, 2025 09:01
@b0ch3nski
Copy link
Contributor Author

@borgmanJeremy rebased and made clang format happy 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borgmanJeremy borgmanJeremy borgmanJeremy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@b0ch3nski @borgmanJeremy