add loadMore button in Upload History widget (issue #3208) #3907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mael-hf
commented
Apr 13, 2025
•
mael-hf
commented
- fixes issue Allow more than 50 items (>500) in upload history #3208
- I created a new storage called secondaryStorage, which keeps in memory the excess images.
- the total number of images stored is 500 (as defined in src/utils/history.cpp and proposed in the issue).
- the loadMore button is always at the bottom of the UI, except when there aren't anymore images to load, then it disappears.
- fixes issue flameshot-org#3208 : flameshot-org#3208 - I created a new storage called secondaryStorage, which keeps in memory the excess images. - the total number of images stored is 500 (as defined in src/utils/history.cpp). - the loadMore button is always at the bottom of the UI, except when there aren't anymore images to load, then it disappears.
-fix a little error that would only load IMAGES_BATCH_SIZE instead of uploadhistorymax (defined in src/config/generalconf.cpp)
|
Thanks for the contribution. The code looks good and clean to me apart from one comment I made. Let's also wait and see what other devs think about this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.