[Flang2] Fix duplicate TBAA type systems across modules #1460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanpkc
reviewed
Nov 12, 2024
1997alireza
force-pushed
the
fix-tbaa-duplicate
branch
from
53ccbcf to
2c87a33
Compare
bryanpkc
reviewed
Nov 13, 2024
1997alireza
force-pushed
the
fix-tbaa-duplicate
branch
from
2c87a33 to
c9c1b80
Compare
bryanpkc
reviewed
Nov 14, 2024
bryanpkc
reviewed
Nov 15, 2024
bryanpkc
reviewed
Nov 15, 2024
1997alireza
force-pushed
the
fix-tbaa-duplicate
branch
from
c9c1b80 to
1e06efc
Compare
bryanpkc
reviewed
Nov 27, 2024
1997alireza
force-pushed
the
fix-tbaa-duplicate
branch
4 times, most recently
from
5f2b4e0 to
96619fa
Compare
bryanpkc
reviewed
Dec 3, 2024
1997alireza
force-pushed
the
fix-tbaa-duplicate
branch
from
96619fa to
dc23925
Compare
pawosm-arm
reviewed
Dec 4, 2024
pawosm-arm
approved these changes
Dec 4, 2024
Collaborator
pawosm-arm
left a comment
pawosm-arm
left a comment
There was a problem hiding this comment.
LGTM, just asked one control question.
In Flang, functions within the same module are assigned unique TBAA type system IDs based on their order, but functions in different modules can unintentionally receive the same ID, leading to incorrect non-aliasing results. This commit resolves the issue by appending a hash of the module name to each function type system metadata, ensuring unique type systems across modules and preventing aliasing errors.
1997alireza
force-pushed
the
fix-tbaa-duplicate
branch
from
dc23925 to
caf490b
Compare
pawosm-arm
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, functions within the same module are assigned unique TBAA type system IDs based on their order, but functions in different modules can unintentionally receive the same ID, leading to incorrect non-aliasing results. This patch resolves the issue by appending a hash of the module name to each function type system metadata, ensuring unique type systems across modules and preventing aliasing errors. This resolves #1458.