-
Notifications
You must be signed in to change notification settings - Fork 25
fix: dropdown width #2794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dropdown width #2794
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughThe changes adjust dropdown menu widths and remove fixed width styling from configuration filter components. A new configurable Changes
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
❌ Deploy Preview for flanksource-demo-stable failed. Why did it fail? →
|
❌ Deploy Preview for clerk-saas-ui failed. Why did it fail? →
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/components/Configs/Changes/ConfigChangesFilters/ConfigTypesTristateDropdown.tsx (1)
54-54: Consider using consistent units across dropdown components.The width adjustment is correct, but this uses
remunits while most other dropdowns in this PR usepxunits (e.g., 300px, 250px, 200px). Usingremprovides better scalability with font-size changes, but inconsistency across components may lead to maintenance confusion.🔎 Optional: Standardize to rem units
Consider standardizing all dropdown widths to use
remunits for better accessibility and responsive behavior:-minMenuWidth="20rem" +minMenuWidth="20rem" // Keep this, but update others to rem as wellAlternatively, if
pxis preferred, convert this to:-minMenuWidth="20rem" +minMenuWidth="320px"
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
src/components/Configs/Changes/ConfigChangesFilters/ConfigTypesTristateDropdown.tsxsrc/components/Configs/ConfigsListFilters/ConfigGroupByDropdown.tsxsrc/components/Configs/ConfigsListFilters/ConfigHealthyDropdown.tsxsrc/components/Configs/ConfigsListFilters/ConfigLabelsDropdown.tsxsrc/components/Configs/ConfigsListFilters/ConfigStatusDropdown.tsxsrc/components/Configs/ConfigsListFilters/ConfigTypesDropdown.tsxsrc/components/Configs/ConfigsListFilters/ConfigsListFilters.tsxsrc/ui/Dropdowns/MultiSelectDropdown.tsx
💤 Files with no reviewable changes (1)
- src/components/Configs/ConfigsListFilters/ConfigStatusDropdown.tsx
⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Redirect rules
- GitHub Check: Header rules
- GitHub Check: Pages changed
🔇 Additional comments (6)
src/components/Configs/ConfigsListFilters/ConfigLabelsDropdown.tsx (1)
148-148: LGTM!The width adjustment to 300px makes the labels dropdown more compact and aligns with the broader UI width standardization across filter components.
src/ui/Dropdowns/MultiSelectDropdown.tsx (1)
21-21: LGTM! Clean implementation of configurable menu width.The new
minMenuWidthprop is well-designed:
- Optional with a sensible 500px default
- Non-breaking change
- Consistently applied to both
menuListandmenustylesThis enables flexible dropdown sizing across the application.
Also applies to: 35-35, 179-180, 187-187
src/components/Configs/ConfigsListFilters/ConfigsListFilters.tsx (1)
36-36: LGTM! Width adjustment aligns with dropdown sizing.Reducing the search input width from 400px to 250px creates better visual consistency with the adjusted dropdown widths across the filter components.
src/components/Configs/ConfigsListFilters/ConfigHealthyDropdown.tsx (1)
56-56: LGTM! Width increase improves readability.Increasing the minimum menu width from 150px to 200px provides better spacing for health status options and aligns with the overall width standardization.
src/components/Configs/ConfigsListFilters/ConfigGroupByDropdown.tsx (1)
155-155: LGTM! Consistent width with other filter dropdowns.Adding
minMenuWidth="250px"standardizes the dropdown width and removes the need for fixed width constraints, making the layout more flexible.src/components/Configs/ConfigsListFilters/ConfigTypesDropdown.tsx (1)
78-78: LGTM! Consistent width with other filter dropdowns.The 250px minimum width standardizes the config types dropdown with other filter components (ConfigGroupByDropdown, search input), creating a more cohesive UI layout.
resolves: #2793
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.