-
Notifications
You must be signed in to change notification settings - Fork 1
feat: azure health #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: azure health #176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds health checks for Azure App Registration client secrets (and certificates) by implementing a new GetAzureHealth function, wiring it into the main health router, and providing fixtures and tests to validate healthy, expiring, and expired states.
- Implement
GetAzureHealthwith default and configurable expiry grace period - Integrate Azure health into
GetHealthByConfigTypeand allow overriding the grace period - Add YAML fixtures and table-driven tests covering healthy, expiring, and expired client secrets
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/health/testdata/azure-client-secret-*.yaml | New test fixtures for Azure client secret health states |
| pkg/health/health_azure.go | New Azure health logic and expiry handling |
| pkg/health/health_azure_test.go | Table-driven tests for the new health logic |
| pkg/health/health.go | Register Azure in the main health router and load configurable grace period |
Comments suppressed due to low confidence (2)
pkg/health/health_azure.go:16
- The variable
azureClientSecretExpiryrepresents a grace period rather than an absolute expiry; consider renaming toazureClientSecretExpiryGracePeriodfor clarity.
azureClientSecretExpiry = defaultAzureClientSecretExpiry
pkg/health/health_azure_test.go:54
- The certificate case (
Azure::AppRegistration::Certificate) is handled in production code but not covered by tests; add a fixture and test case for certificate expiry/healthy states.
{
4415a61 to
f9b376e
Compare
related: flanksource/config-db#1463