Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): add support for hardhat FTSO guide and fix FTSO interfaces #608

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

AmadiaFlare
Copy link
Collaborator

PR adds a guide for Hardhat FTSO walkthrough, fixes test interfaces to use FTSO, and changes FTSO methods from payable to view.

@swarna1101
Copy link
Collaborator

thanks for your PR, make sure all the workflows are passing.

@AmadiaFlare AmadiaFlare changed the title Add support for Hardhat FTSO guide feat(docs): add support for hardhat FTSO guide and fix FTSO interfaces Mar 20, 2025
dineshpinto
dineshpinto previously approved these changes Mar 22, 2025
swarna1101
swarna1101 previously approved these changes Mar 23, 2025
@swarna1101 swarna1101 dismissed stale reviews from dineshpinto and themself via 3ff7cfc March 23, 2025 19:25
swarna1101
swarna1101 previously approved these changes Mar 23, 2025
@@ -0,0 +1,53 @@
import { artifacts, ethers } from "hardhat";
import { expect } from "chai";
import { deployFlareContractRegistry } from "../lib/utils";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this live?

let ftsoConsumer;
const mockFtsoV2Address = "0x1234567890123456789012345678901234567890";
const mockFeeCalcAddress = "0x2345678901234567890123456789012345678901";
const mockFlrUsdId = "0x0123456789012345678901234567890123456789012345";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magic numbers?

import { artifacts, ethers } from "hardhat";
import { FtsoV2FeedConsumerInstance } from "../typechain-types";

const FtsoV2FeedConsumer = artifacts.require("FtsoV2FeedConsumer");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which contract does this one refer to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants