-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docs): add support for hardhat FTSO guide and fix FTSO interfaces #608
base: main
Are you sure you want to change the base?
Conversation
thanks for your PR, make sure all the workflows are passing. |
@@ -0,0 +1,53 @@ | |||
import { artifacts, ethers } from "hardhat"; | |||
import { expect } from "chai"; | |||
import { deployFlareContractRegistry } from "../lib/utils"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does this live?
let ftsoConsumer; | ||
const mockFtsoV2Address = "0x1234567890123456789012345678901234567890"; | ||
const mockFeeCalcAddress = "0x2345678901234567890123456789012345678901"; | ||
const mockFlrUsdId = "0x0123456789012345678901234567890123456789012345"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Magic numbers?
import { artifacts, ethers } from "hardhat"; | ||
import { FtsoV2FeedConsumerInstance } from "../typechain-types"; | ||
|
||
const FtsoV2FeedConsumer = artifacts.require("FtsoV2FeedConsumer"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which contract does this one refer to?
PR adds a guide for Hardhat FTSO walkthrough, fixes test interfaces to use FTSO, and changes FTSO methods from
payable
toview
.