Skip to content

feat(docs): add flare smart accounts overview#919

Merged
nikerzetic-aflabs merged 10 commits intomainfrom
flare-smart-accounts
Sep 19, 2025
Merged

feat(docs): add flare smart accounts overview#919
nikerzetic-aflabs merged 10 commits intomainfrom
flare-smart-accounts

Conversation

@nikerzetic-aflabs
Copy link
Collaborator

No description provided.

@nikerzetic-aflabs nikerzetic-aflabs marked this pull request as draft September 16, 2025 09:17
@nikerzetic-aflabs nikerzetic-aflabs force-pushed the flare-smart-accounts branch 2 times, most recently from 69571e7 to 7f0223b Compare September 16, 2025 09:45
Copy link
Collaborator

@TheVictorMunoz TheVictorMunoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments:

2- fasset-instructions:

some typos:

over-collateralize bridge” → “over-collateralized bridge.”

“hold FLR token for paying gas fees” → should be plural: “hold FLR tokens to pay gas fees.”

Thus, the eradicate completely the need” → “Thus, they completely eradicate the need”

“Deposit an amount of FXRP from you account” → should be “Deposit an amount of FXRP from your account.”

Also, should we add the encoding example for Withdraw (02)?


3-custom-instructions

“The Flare Smart Accounts is an account abstraction” → “Flare Smart Accounts are an account abstraction.”

“The workflow for Flare Smart Accounts is comprised of the following steps.” → “The workflow for Flare Smart Accounts consists of the following steps.”

“The Flare Smart Accounts allows XRPL users…” → “Flare Smart Accounts allow XRPL users…”

Maybe the "payment receipt is a bytes32 value” piece would be clearer if you included a concrete encoding example...

@nikerzetic-aflabs nikerzetic-aflabs force-pushed the flare-smart-accounts branch 3 times, most recently from 45d7cf3 to c99a499 Compare September 17, 2025 08:54
@nikerzetic-aflabs nikerzetic-aflabs force-pushed the flare-smart-accounts branch 2 times, most recently from 1598312 to 4373d08 Compare September 19, 2025 12:28
@nikerzetic-aflabs nikerzetic-aflabs marked this pull request as ready for review September 19, 2025 14:54
@nikerzetic-aflabs nikerzetic-aflabs merged commit 893b444 into main Sep 19, 2025
13 checks passed
@nikerzetic-aflabs nikerzetic-aflabs deleted the flare-smart-accounts branch September 19, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants