feat(docs): swap USDT0 to FXRP using Uniswap V3 guide#976
Conversation
|
|
||
| // 1. Defines Uniswap V3 router functions for swaps | ||
| interface ISwapRouter { | ||
| struct ExactInputSingleParams { |
There was a problem hiding this comment.
Why are you defining the interfaces here? Don't they have an official package that you can import from?
...
I found this: https://www.npmjs.com/package/@uniswap/v3-periphery?activeTab=code .
There was a problem hiding this comment.
We talked with @jO-Osko that I will add a link to it, but not include it in the starter kits.
There was a problem hiding this comment.
Then add a :::note field somewhere in the guide, explicitly stating that you have defined the structs here, but that they should use the official library.
fassko
force-pushed
the
feat/fassets-uniswapv3-swap
branch
2 times, most recently
from
78970df to
8e99ada
Compare
| await deployAndVerifyContract(); | ||
|
|
||
| const { deployer, usdt0, fxrp, initialUsdt0Balance, initialFxrpBalance } = | ||
| await setupAndInitializeTokens(); |
There was a problem hiding this comment.
setUpAndInitializeTokens
|
|
||
| ## Required Addresses on Flare Mainnet | ||
|
|
||
| - V3 SwapRouter (SparkDEX): [0x8a1E35F5c98C4E85B36B7B253222eE17773b2781](https://flarescan.com/address/0x8a1E35F5c98C4E85B36B7B253222eE17773b2781/contract/14/code). |
There was a problem hiding this comment.
I've been defaulting to Flare Explorer, not Flarescan.
There was a problem hiding this comment.
Sadly, it is not verified on Flare Explorer.
…AssetManager import
fassko
force-pushed
the
feat/fassets-uniswapv3-swap
branch
from
8e99ada to
3c750d2
Compare
…izeTokens for consistency
3 participants
No description provided.