fix: Automatic detection and backfilling of gaps in block history at startup#4
Open
mouradski wants to merge 1 commit intoflare-foundation:mainfrom
Open
fix: Automatic detection and backfilling of gaps in block history at startup#4mouradski wants to merge 1 commit intoflare-foundation:mainfrom
mouradski wants to merge 1 commit intoflare-foundation:mainfrom
Conversation
…startup mouradski 3 minutes ago
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
During batch indexing, if a block fails to insert (timeout, constraint violation, etc.), it is silently ignored due to INSERT IGNORE.
On application restart, the indexer would simply resume after MAX(number) from the blocks table, leaving permanent gaps in the history.
Example:
Blocks in DB: [1000, 1001, 1002, 1005, 1006] ← blocks 1003-1004 missing
Previous behavior: restart → starts at 1007
Result: blocks 1003-1004 are permanently lost
Solution:
Robustness:
✅ Executed once at startup → negligible cost
✅ Self-healing → after a crash, the next restart automatically fills gaps
✅ Performance → SQL query is O(n log n) with index on number
✅ Backward compatible → unchanged behavior if no gaps detected