feat(statistics): support for custom date ranges - #3622
Merged
Conversation
davwheat
force-pushed
the
dw/stats-custom-start-end-date
branch
from
September 4, 2022 01:28
a34c8ec to
82ebf32
Compare
davwheat
marked this pull request as ready for review
September 7, 2022 23:38
davwheat
changed the title
SychO9
reviewed
Sep 18, 2022
| } | ||
|
|
||
| export default class StatisticsWidgetDateSelectionModal extends Modal<IStatisticsWidgetDateSelectionModalAttrs> { | ||
| /* @ts-expect-error core typings don't allow us to set the type of the state attr :( */ |
Contributor
There was a problem hiding this comment.
noticed this too, I guess like we have to always type a default state/attribute type in any core components to not hinder extensibility going forward?
Contributor
Author
There was a problem hiding this comment.
Yeah, we've done it in some components, but not all.
Just a "simple" class MyComponent<CustomAttrs extends BaseAttrs = BaseAttrs, CustomState extends BaseState> extends BaseComponent<CustomAttrs, CustomState> should work.
Co-authored-by: Sami Mazouz <sychocouldy@gmail.com>
Co-authored-by: Sami Mazouz <sychocouldy@gmail.com>
Co-authored-by: Sami Mazouz <sychocouldy@gmail.com>
SychO9
approved these changes
Sep 26, 2022
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
8 tasks
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Reviewers should focus on:
Screenshot
Necessity
Confirmed
composer test).