-
-
Notifications
You must be signed in to change notification settings - Fork 881
feat: contrast util with yiq calculator #3652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
806e0ad
add yiq calculator util
ornanovitch 48b3c07
fix: convert 3 chars hex to 6 chars hex
ornanovitch bd0e663
fix: clarify util name
ornanovitch 0c888f6
feat: add text color variables not depending on the dark/light mode
ornanovitch 99b5036
refactor: change getContrast to isDark with for a more direct approach
ornanovitch ad06247
fix: adjust snippet description
ornanovitch 4966bde
chore: change `var` to `let`
davwheat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| /** | ||
| * The `isDark` utility converts a hex color to rgb, and then calcul a YIQ | ||
| * value in order to get the appropriate brightness value (is it dark or is it | ||
| * light?) See https://www.w3.org/TR/AERT/#color-contrast for references. A YIQ | ||
| * value >= 128 is a light color. | ||
| */ | ||
|
|
||
| export default function isDark(hexcolor: String) { | ||
|
|
||
| var hexnumbers = hexcolor.replace("#", ""); | ||
|
davwheat marked this conversation as resolved.
Outdated
|
||
|
|
||
| if (hexnumbers.length == 3) { | ||
| hexnumbers += hexnumbers; | ||
| } | ||
|
|
||
| const r = parseInt(hexnumbers.substr(0,2),16); | ||
| const g = parseInt(hexnumbers.substr(2,2),16); | ||
| const b = parseInt(hexnumbers.substr(4,2),16); | ||
| const yiq = ((r*299)+(g*587)+(b*114))/1000; | ||
|
|
||
| return (yiq >= 128) ? false : true; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.