Skip to content

feat: send notifications of a new reply when post is approved - #3656

Merged
imorland merged 2 commits into
mainfrom
sm/notifications-for-approved-posts
Nov 7, 2022
Merged

feat: send notifications of a new reply when post is approved#3656
imorland merged 2 commits into
mainfrom
sm/notifications-for-approved-posts

Conversation

@SychO9

@SychO9 SychO9 commented Oct 12, 2022

Copy link
Copy Markdown
Contributor

Changes proposed in this pull request:
Replies held for approval naturally don't send out notifications to users, however currently after a post has been approved users are still not notified that a reply has been posted.

This PR tweaks subscriptions to send notifications once a reply has been approved.

Reviewers should focus on
The code in approval was extracted into a listener because no matter what listeners are always executed before subscribers even if the extension is set to load before.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
The code in approval was extracted into a listener because no matter what listeners are always executed before subscribers even if the extension is set to load before.

Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9
SychO9 requested a review from a team as a code owner October 12, 2022 09:47
@SychO9 SychO9 self-assigned this Oct 15, 2022

@imorland imorland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@imorland imorland added this to the 1.6 milestone Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants