feat: send notifications of a new reply when post is approved - #3656
Merged
Conversation
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
The code in approval was extracted into a listener because no matter what listeners are always executed before subscribers even if the extension is set to load before. Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
davwheat
approved these changes
Nov 7, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Replies held for approval naturally don't send out notifications to users, however currently after a post has been approved users are still not notified that a reply has been posted.
This PR tweaks subscriptions to send notifications once a reply has been approved.
Reviewers should focus on
The code in approval was extracted into a listener because no matter what listeners are always executed before subscribers even if the extension is set to load before.
Necessity
Confirmed
composer test).