Skip to content

Adjust size of FontAwesome icons on extensions list to match size of custom images - #3771

Closed
rob006 wants to merge 1 commit into
flarum:mainfrom
rob006:extensions-icons
Closed

Adjust size of FontAwesome icons on extensions list to match size of custom images#3771
rob006 wants to merge 1 commit into
flarum:mainfrom
rob006:extensions-icons

Conversation

@rob006

@rob006 rob006 commented Mar 19, 2023

Copy link
Copy Markdown
Contributor

Before:

223952bb

After:

a2f51291

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@rob006
rob006 requested a review from a team as a code owner March 19, 2023 15:03
@imorland imorland added this to the 1.8 milestone Mar 21, 2023
@SychO9

SychO9 commented Apr 10, 2023

Copy link
Copy Markdown
Contributor

@rob006 are you using any custom themes? this does not seem to be the case in default flarum, font sizes are already made relative to the size

@rob006

rob006 commented Apr 11, 2023

Copy link
Copy Markdown
Contributor Author

@SychO9 You're right, this is caused by malago/flarum-achievements:

7dd82bca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants