fix: circular dependencies disable all involved extensions - #3785
Merged
Conversation
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
askvortsov1
reviewed
Apr 10, 2023
askvortsov1
left a comment
Contributor
There was a problem hiding this comment.
Should we also reject attempts to enable extensions that would cause circular dependencies?
Contributor
Author
|
That would already be rejected as well, whether the extension being enabled causes the circular dependency. Or whether there is an existing circular dependency with other already enabled extensions (due to an update). The error is thrown. |
askvortsov1
approved these changes
Apr 10, 2023
askvortsov1
left a comment
Contributor
There was a problem hiding this comment.
Ah right, this would run when enabled extensions are persisted. Looks good!
luceos
approved these changes
Apr 11, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Throws an exception wen circular dependencies are found, which prevents the extensions within the circular depdencies fro getting all disabled.
Screenshot

This is an example where I created a circular dependency with emoji, suspend, and likes:
Necessity
Confirmed
composer test).Required changes: