fix: notification subject discussion eager loading fails - #3788
Merged
Conversation
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
askvortsov1
approved these changes
Apr 16, 2023
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3778
Changes proposed in this pull request:
In 1.7 the
property_existscheck was added to fix PHP 8.2 deprecations but missed the fact that dynamic properties cannot be checked like that.I don't believe this is the problem described in the issue however, only 10 notifications are loaded at a time. So it could be a bad extension.
Necessity
Confirmed
composer test).