Skip to content

fix: null as 2nd param in preg_match is deprecated - #3801

Merged
luceos merged 1 commit into
mainfrom
im/translator
Apr 19, 2023
Merged

fix: null as 2nd param in preg_match is deprecated#3801
luceos merged 1 commit into
mainfrom
im/translator

Conversation

@imorland

@imorland imorland commented Apr 19, 2023

Copy link
Copy Markdown
Member

**Replaces #3783 **

Changes proposed in this pull request:
Deprecated: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated in /var/www/framework/framework/core/src/Locale/Translator.php on line 65

Reviewers should focus on:

Screenshot

QA

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@imorland
imorland requested a review from a team as a code owner April 19, 2023 13:25
@imorland imorland self-assigned this Apr 19, 2023
@imorland imorland added this to the 1.8 milestone Apr 19, 2023
@imorland imorland mentioned this pull request Apr 19, 2023
7 tasks
@imorland imorland changed the title fix: null as 2nd param is deprecated fix: null as 2nd param in preg_match is deprecated Apr 19, 2023
@luceos
luceos merged commit 8576df1 into main Apr 19, 2023
@luceos
luceos deleted the im/translator branch April 19, 2023 17:07
@github-actions github-actions Bot mentioned this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants