Skip to content

fix(testing): always clear cache in integration test's tearDown - #3818

Merged
SychO9 merged 1 commit into
flarum:mainfrom
n-peugnet:flush-cache-in-teardown
May 2, 2023
Merged

fix(testing): always clear cache in integration test's tearDown#3818
SychO9 merged 1 commit into
flarum:mainfrom
n-peugnet:flush-cache-in-teardown

Conversation

@n-peugnet

@n-peugnet n-peugnet commented May 2, 2023

Copy link
Copy Markdown
Contributor

Changes proposed in this pull request:

This prevent integration tests from interacting between each other through the cache. See #3663 (comment).

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

This prevent tests from interacting between each other through the cache.
@n-peugnet
n-peugnet requested a review from a team as a code owner May 2, 2023 17:32

@SychO9 SychO9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SychO9 SychO9 changed the title fix: always clear cache in integration test's tearDown fix(testing): always clear cache in integration test's tearDown May 2, 2023
@SychO9
SychO9 merged commit 3264455 into flarum:main May 2, 2023
@SychO9 SychO9 added this to the 1.8 milestone May 2, 2023
@github-actions github-actions Bot mentioned this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants