Skip to content

[1.x] fix: userOnline can render as null, causing the page to break - #4257

Merged
imorland merged 2 commits into
1.xfrom
im/fix-online-indicator
Oct 8, 2025
Merged

[1.x] fix: userOnline can render as null, causing the page to break#4257
imorland merged 2 commits into
1.xfrom
im/fix-online-indicator

Conversation

@imorland

@imorland imorland commented Oct 8, 2025

Copy link
Copy Markdown
Member

Fixes #0000

Changes proposed in this pull request:
Fixes a regression introduced during 1.8.11 development that caused the userOnline helper to render null in the dom

Reviewers should focus on:

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

@imorland
imorland requested a review from a team as a code owner October 8, 2025 17:28
@imorland
imorland force-pushed the im/fix-online-indicator branch from 5e0281f to 669f044 Compare October 8, 2025 17:29
@imorland imorland added this to the 1.8.11 milestone Oct 8, 2025
@imorland
imorland merged commit 8b3aaf1 into 1.x Oct 8, 2025
360 checks passed
@imorland
imorland deleted the im/fix-online-indicator branch October 8, 2025 17:54
@imorland imorland changed the title fix: userOnline can render as null, causing the page to break [1.x] fix: userOnline can render as null, causing the page to break Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant