Skip to content

[1.x] feat(core): allow to disable slidable on DiscussionListItem - #4302

Merged
imorland merged 1 commit into
flarum:1.xfrom
glowingblue:di/slideable-underneath-extensibility
Dec 2, 2025
Merged

[1.x] feat(core): allow to disable slidable on DiscussionListItem#4302
imorland merged 1 commit into
flarum:1.xfrom
glowingblue:di/slideable-underneath-extensibility

Conversation

@DavideIadeluca

@DavideIadeluca DavideIadeluca commented Dec 2, 2025

Copy link
Copy Markdown
Contributor

1.x equivalent to #4303

Fixes #0000
No straight forward way to disable the Slidable Underneath Functionality on the DiscussionListItem

Changes proposed in this pull request:
Add new slidable attribute to the DiscussionListItem which allows to cleanly disable the slidable underneath functionality on the DiscussionListItem

Reviewers should focus on:
This PR is the most surgical change to preserve backwards compatibility as much as possible.

Here is how extensions can consume those new extensibility improvements:

override(DiscussionListItem.prototype, 'isSlidableEnabled', function () {
    return false;
  });

or

<DiscussionListItem discussion={discussion} params={params} slidable={false} />

This attribute is fully optional and doesn't have or need a default value of true.

Screenshot
n.a.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

@DavideIadeluca DavideIadeluca changed the title feat(core): allow to disable slidable on DiscussionListItem [1.x] feat(core): allow to disable slidable on DiscussionListItem Dec 2, 2025
@DavideIadeluca
DavideIadeluca marked this pull request as ready for review December 2, 2025 08:21
@DavideIadeluca
DavideIadeluca requested a review from a team as a code owner December 2, 2025 08:21
@imorland imorland added this to the 1.8.12 milestone Dec 2, 2025
@imorland
imorland merged commit 9b28a9a into flarum:1.x Dec 2, 2025
321 checks passed
@imorland
imorland deleted the di/slideable-underneath-extensibility branch December 2, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants