[1.x] fix: delete stale password tokens when requesting a new reset - #4547
Merged
Conversation
imorland
changed the title
Each password reset request generated a new token without removing prior ones, leaving multiple valid tokens accumulating in the database indefinitely. Any of these tokens could be exploited if obtained. Now clears all existing tokens for the user before generating a new one.
imorland
force-pushed
the
im/security-password-reset-token-accumulation
branch
from
April 11, 2026 11:31
97ce05a to
9088304
Compare
imorland
marked this pull request as ready for review
April 11, 2026 12:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RequestPasswordResetJobTest plan
PasswordResetTokenAccumulationTest::existing_password_tokens_are_deleted_when_new_reset_is_requested— fails before fix, passes afterPasswordEmailTokensTestsuite — no regressions