[2.x] fix: keep the unread comment icon's weight out of the forced style - #4878
Merged
Conversation
The discussion list signals unread replies by icon weight alone: a solid comment for unread against a regular one for read. Forcing a FontAwesome style restyled both to the same weight, making the two states indistinguishable. The unread icon now opts out with noStyleOverride, the same exemption the online indicator and subscription stars use (#4873). The read-state icon still follows the forced style, so the contrast survives — the checkmark shown on hover is an action glyph, not a weight signal, and keeps following the forced style too.
imorland
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4873, same class of bug: the discussion list signals unread replies by icon weight alone —
fas fa-comment(solid) for unread againstfar fa-comment(regular) for read. With a forced FontAwesome style configured, both restyled to the same weight and the two states became indistinguishable.The unread icon now opts out with
noStyleOverride, exactly like the online indicator and subscription stars.Deliberately left following the forced style:
far fa-comment— that's the uniform-styling case the admin asked for, and restyling only the read side preserves the solid-vs-styled contrast;fa-check(mark-as-read affordance) — an action glyph, not a weight signal, so it falls on the same side of [2.x] fix: keep icons whose style carries meaning out of the forced style #4873's line as the tags toggle.Verified: typecheck and Prettier clean. The visual (authenticated session, unread badge, override active) uses the identical mechanism manually verified in #4873.