Skip to content

Quality: Silent data corruption from ignored SetString error in NewBuilderBids #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kumburovicbranko682-boop wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Quality: Silent data corruption from ignored SetString error in NewBuilderBids #789

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions datastore/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package datastore
import (
"context"
"errors"
"fmt"
"math/big"

"github.com/redis/go-redis/v9"
Expand All @@ -25,18 +26,21 @@ func NewBuilderBidsFromRedis(ctx context.Context, r *RedisCache, pipeliner redis
if err != nil {
return nil, err
}
return NewBuilderBids(bidValueMap), nil
return NewBuilderBids(bidValueMap)
}

func NewBuilderBids(bidValueMap map[string]string) *BuilderBids {
func NewBuilderBids(bidValueMap map[string]string) (*BuilderBids, error) {
b := BuilderBids{
bidValues: make(map[string]*big.Int),
}
for builderPubkey, bidValue := range bidValueMap {
b.bidValues[builderPubkey] = new(big.Int)
b.bidValues[builderPubkey].SetString(bidValue, 10)
v, ok := new(big.Int).SetString(bidValue, 10)
if !ok {
return nil, fmt.Errorf("invalid bid value for builder %s: %q", builderPubkey, bidValue)
}
b.bidValues[builderPubkey] = v
}
return &b
return &b, nil
}

func (b *BuilderBids) getTopBid() (string, *big.Int) {
Expand Down